From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1580CC433EF for ; Tue, 26 Jul 2022 13:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238668AbiGZNNO (ORCPT ); Tue, 26 Jul 2022 09:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232549AbiGZNNN (ORCPT ); Tue, 26 Jul 2022 09:13:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6AAA8248DC for ; Tue, 26 Jul 2022 06:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658841191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8lGwWcKgXjbZMsb7f3KkrDpC0QKsfV0t/BrUUpRw1V4=; b=UQ/1ooDogJfwE2NjbF5MpAf7ghV4wsBUm+yWqkakD2ITdjH8XU9ltaJADD0WbV5tTZQvWh H3WWCs9RiZ3k+plqNnypaCGWmFExgBNMN2E8FAuhSEASpGxkm3V886m/yYlDqkGjxcLUmn LhQwlBsUIXTLzWhfeSSVMU/lzIHlIL0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-402-ZNs6M0RYMWmMFdM8eCT6vg-1; Tue, 26 Jul 2022 09:13:10 -0400 X-MC-Unique: ZNs6M0RYMWmMFdM8eCT6vg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48F57802D1C; Tue, 26 Jul 2022 13:13:09 +0000 (UTC) Received: from localhost (unknown [10.39.192.224]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EECF81415118; Tue, 26 Jul 2022 13:13:08 +0000 (UTC) From: Cornelia Huck To: Abhishek Sahu , Alex Williamson Cc: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , "Rafael J . Wysocki" , Max Gurtovoy , Bjorn Helgaas , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v5 1/5] vfio: Add the device features for the low power entry and exit In-Reply-To: Organization: Red Hat GmbH References: <20220719121523.21396-1-abhsahu@nvidia.com> <20220719121523.21396-2-abhsahu@nvidia.com> <20220721163445.49d15daf.alex.williamson@redhat.com> <20220725160928.43a17560.alex.williamson@redhat.com> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Date: Tue, 26 Jul 2022 15:13:07 +0200 Message-ID: <87fsiom2zg.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26 2022, Abhishek Sahu wrote: > #define VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP 4 > > /* > * Upon VFIO_DEVICE_FEATURE_SET, disallow use of device low power states as > * previously enabled via VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY or > * VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP device features. > * This device feature IOCTL may itself generate a wakeup eventfd notification > * in the latter case if the device has previously entered a low power state. Nit: s/has/had/ > */ > #define VFIO_DEVICE_FEATURE_LOW_POWER_EXIT 5 I haven't followed this closely, and I'm not that familiar with power management, but at least I can't spot anything obviously problematic.