From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D29C433F5 for ; Tue, 12 Apr 2022 11:58:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347500AbiDLMAo (ORCPT ); Tue, 12 Apr 2022 08:00:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349365AbiDLL5t (ORCPT ); Tue, 12 Apr 2022 07:57:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82A6D60DB5; Tue, 12 Apr 2022 03:47:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2CD02B81CBB; Tue, 12 Apr 2022 10:47:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C90C5C385A1; Tue, 12 Apr 2022 10:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649760424; bh=8nrqqM3IkuVaMYtRsABBZlIcS5QBrVTQAj/P3+5fYYI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IFJ0f4ZD3Llfeaj09qoCE9fqavR0fqRwZhrOfd+ghn84ggQnDQE8GFnbmO08hqc8c JU2zcJpWxRU9xlS2+iOAJVmdlpFlYPlfjMaZ+TgCK19Tk0XJ4Xehrzzr0XlQGF9/Mm d/U1TWLuYMyucl59ci/bEKB6t+9Zu5cmuypNYgNrNXp/8dTfQd1FYIUgiJ/j5MoDyR D0llTsWIxesJzjKOrQy6NdDLgGXJE8RK2eUESE9sWSpQVCZ9xXaQDO/hyUmOQ8YWjo T/KN8c4LpQexG+qvay1ZBzDW2gRysRhGBVsJjK6plN+gbY/I5FgCgpoxQIt9r01whD mtGRjmuH7zPXg== From: Kalle Valo To: Abhishek Kumar Cc: Doug Anderson , Rakesh Pillai , LKML , linux-wireless , "David S. Miller" , Jakub Kicinski , ath10k , netdev Subject: Re: [PATCH 1/2] ath10k: search for default BDF name provided in DT References: <20220107200417.1.Ie4dcc45b0bf365077303c596891d460d716bb4c5@changeid> <87sfrqqfzy.fsf@kernel.org> Date: Tue, 12 Apr 2022 13:46:55 +0300 In-Reply-To: (Abhishek Kumar's message of "Mon, 11 Apr 2022 16:25:10 -0700") Message-ID: <87fsmio9y8.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Abhishek Kumar writes: > Hi All, > > Apologies for the late reply, too many things at the same time. Trust me, I know the feeling :) > Just a quick note, Qcomm provided a new BDF file with support for > 'bus=snoc,qmi-board-id=ff' as well, so even without this patch, the > non-programmed devices(with board-id=0xff) would work. However, for > optimization of the BDF search strategy, the above mentioned strategy > would still not work: - The stripping of full Board name would not > work if board-id itself is not programmed i.e. =0xff e.g. for > 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320,variant=GO_LAZOR' => no > match 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320' => no match > 'bus=snoc,qmi-board-id=ff' => no match 'bus=snoc' => no match because > all the BDFs contains board-id=67 Sorry, not fully following your here. Are you saying that the problem is that WCN3990/hw1.0/board-2.bin is missing board file for 'bus=snoc'? That's easy to add, each board file within board-2.bin has multiple names so we can easily select one board file for which we add 'bus=snoc'. > So with this DT patch specifically for case 'bus=snoc,qmi-board-id=ff' > => no match, we fallback to default case ( the one provided in DT) > i.e. 'bus=snoc,qmi-board-id=67' => match . I do not see how exactly > the driver can know that it should check for a board-id of 67. Sorry, not following you here either. Why would the driver need to use board-id 67? > However, to still remove dependency on the DT, we can make the > board-id as no-op if it is not programmed i.e. if the board-id=ff then > we would pick any BDF that match 'bus=snoc,qmi-board-id=' where XX > can be any arbitrary number. Thoughts ? To me using just 'bus=snoc' is more logical than picking up an arbitrary number. But I might be missing something here. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches