From: Michael Ellerman <mpe@ellerman.id.au>
To: Nanyong Sun <sunnanyong@huawei.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
benh@kernel.crashing.org, paulus@samba.org,
akpm@linux-foundation.org, npiggin@gmail.com,
christophe.leroy@c-s.fr
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
wangkefeng 00584194 <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH -next] powerpc/mm: check base flags in ioremap_prot
Date: Sat, 04 Sep 2021 21:20:25 +1000 [thread overview]
Message-ID: <87fsukzix2.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <e27f8786-7d43-4191-9b65-5a55a64cf158@huawei.com>
Nanyong Sun <sunnanyong@huawei.com> writes:
> On 2021/9/3 17:16, Christophe Leroy wrote:
>> Le 03/09/2021 à 11:03, Nanyong Sun a écrit :
>>> Some drivers who call ioremap_prot without setting base flags like
>>> ioremap_prot(addr, len, 0) may work well before
>>> commit 56f3c1413f5c ("powerpc/mm: properly set PAGE_KERNEL flags in
>>> ioremap()"), but now they will get a virtual address "successfully"
>>> from ioremap_prot and badly fault on memory access later because that
>>> patch also dropped the hack adding of base flags for ioremap_prot.
>>>
>>> So return NULL and throw a warning if the caller of ioremap_prot did
>>> not set base flags properly. Why not just hack adding PAGE_KERNEL flags
>>> in the ioremap_prot, because most scenarios can be covered by high level
>>> functions like ioremap(), ioremap_coherent(), ioremap_cache()...
>>> so it is better to keep max flexibility for this low level api.
>>
>> As far as I can see, there is no user of this fonction that sets flags
>> to 0 in the kernel tree.
>>
>> Did you find any ? If you did, I think it is better to fix the caller.
>>
>> Christophe
>>
> I see some vendor's drivers which are not on upstream ...
Sorry, but we don't carry extraneous checks in upstream for the sake of
out-of-tree drivers.
cheers
prev parent reply other threads:[~2021-09-04 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 9:03 [PATCH -next] powerpc/mm: check base flags in ioremap_prot Nanyong Sun
2021-09-03 9:16 ` Christophe Leroy
[not found] ` <e27f8786-7d43-4191-9b65-5a55a64cf158@huawei.com>
2021-09-04 11:20 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsukzix2.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).