archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <>
To: Nanyong Sun <>,
	Christophe Leroy <>,,,,,
	wangkefeng 00584194 <>
Subject: Re: [PATCH -next] powerpc/mm: check base flags in ioremap_prot
Date: Sat, 04 Sep 2021 21:20:25 +1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Nanyong Sun <> writes:
> On 2021/9/3 17:16, Christophe Leroy wrote:
>> Le 03/09/2021 à 11:03, Nanyong Sun a écrit :
>>> Some drivers who call ioremap_prot without setting base flags like
>>> ioremap_prot(addr, len, 0) may work well before
>>> commit 56f3c1413f5c ("powerpc/mm: properly set PAGE_KERNEL flags in
>>> ioremap()"), but now they will get a virtual address "successfully"
>>> from ioremap_prot and badly fault on memory access later because that
>>> patch also dropped the hack adding of base flags for ioremap_prot.
>>> So return NULL and throw a warning if the caller of ioremap_prot did
>>> not set base flags properly. Why not just hack adding PAGE_KERNEL flags
>>> in the ioremap_prot, because most scenarios can be covered by high level
>>> functions like ioremap(), ioremap_coherent(), ioremap_cache()...
>>> so it is better to keep max flexibility for this low level api.
>> As far as I can see, there is no user of this fonction that sets flags 
>> to 0 in the kernel tree.
>> Did you find any ? If you did, I think it is better to fix the caller.
>> Christophe
> I see some vendor's drivers which are not on upstream ...

Sorry, but we don't carry extraneous checks in upstream for the sake of
out-of-tree drivers.


      parent reply	other threads:[~2021-09-04 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03  9:03 Nanyong Sun
2021-09-03  9:16 ` Christophe Leroy
     [not found]   ` <>
2021-09-04 11:20     ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH -next] powerpc/mm: check base flags in ioremap_prot' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).