From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCD7C433B4 for ; Tue, 18 May 2021 13:12:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83C426109E for ; Tue, 18 May 2021 13:12:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349465AbhERNNa (ORCPT ); Tue, 18 May 2021 09:13:30 -0400 Received: from foss.arm.com ([217.140.110.172]:51732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbhERNN3 (ORCPT ); Tue, 18 May 2021 09:13:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31A93D6E; Tue, 18 May 2021 06:12:11 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B68D83F73B; Tue, 18 May 2021 06:12:09 -0700 (PDT) From: Valentin Schneider To: Ionela Voinescu , Sudeep Holla , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Giovanni Gherdovich , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC In-Reply-To: <20210514095339.12979-1-ionela.voinescu@arm.com> References: <20210514095339.12979-1-ionela.voinescu@arm.com> Date: Tue, 18 May 2021 14:12:03 +0100 Message-ID: <87fsyk190c.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/05/21 10:53, Ionela Voinescu wrote: > Hi all, > > These are a few trivial patches to populate cpu capacity information > using performance information from ACPI's CPPC. > > I've tied this functionality to the existing function > init_freq_invariance_cppc() called in acpi_cppc_processor_probe(). > This function is renamed to a more generic arch_init_invariance_cppc(). > > The patches have been build tested on x86 and more thoroughly tested on > Juno R2 (arm64), which uses the new functionality, with the following > results: > > > root@ubuntu:~# dmesg | grep cpu_capacity > [ 2.157494] init_cpu_capacity_cppc: CPU0 cpu_capacity=38300 (raw). > [ 2.163699] init_cpu_capacity_cppc: CPU1 cpu_capacity=38300 (raw). > [ 2.169899] init_cpu_capacity_cppc: CPU2 cpu_capacity=38300 (raw). > [ 2.176098] init_cpu_capacity_cppc: CPU3 cpu_capacity=38300 (raw). > [ 2.182296] init_cpu_capacity_cppc: CPU4 cpu_capacity=102400 (raw). > [ 2.188581] init_cpu_capacity_cppc: CPU5 cpu_capacity=102400 (raw). > [ 2.194867] cpu_capacity: capacity_scale=102400 > [ 2.199409] cpu_capacity: CPU0 cpu_capacity=383 > [ 2.203952] cpu_capacity: CPU1 cpu_capacity=383 > [ 2.208495] cpu_capacity: CPU2 cpu_capacity=383 > [ 2.213037] cpu_capacity: CPU3 cpu_capacity=383 > [ 2.217580] cpu_capacity: CPU4 cpu_capacity=1024 > [ 2.222209] cpu_capacity: CPU5 cpu_capacity=1024 > [ 2.226886] init_cpu_capacity_cppc: cpu_capacity initialization done > > root@ubuntu:~# tail -n +1 /sys/devices/system/cpu/cpu*/cpu_capacity > ==> /sys/devices/system/cpu/cpu0/cpu_capacity <== > 383 > ==> /sys/devices/system/cpu/cpu1/cpu_capacity <== > 383 > ==> /sys/devices/system/cpu/cpu2/cpu_capacity <== > 383 > ==> /sys/devices/system/cpu/cpu3/cpu_capacity <== > 383 > ==> /sys/devices/system/cpu/cpu4/cpu_capacity <== > 1024 > ==> /sys/devices/system/cpu/cpu5/cpu_capacity <== > 1024 > > All works as expected even if ACPI processor support is built as a > module. > Tested on my Ampere eMAG; this all seems to work fine except for some scheduler debug stuff that gets confused; see http://lore.kernel.org/r/20210518130725.3563132-1-valentin.schneider@arm.com With that in mind: Tested-by: Valentin Schneider