From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] x86/apic: Avoid cm->allocated going negative in irq_matrix
Date: Thu, 11 Mar 2021 11:19:04 +0100 [thread overview]
Message-ID: <87ft129enb.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20210219113101.967508-1-vkuznets@redhat.com>
Vitaly Kuznetsov <vkuznets@redhat.com> writes:
> I discovered that CPU0 offlining/onlining works only once:
>
> # echo 0 > /sys/devices/system/cpu/cpu0/online
> # echo 1 > /sys/devices/system/cpu/cpu0/online
> # echo 0 > /sys/devices/system/cpu/cpu0/online
> -bash: echo: write error: No space left on device
>
> with the following in dmesg:
>
> [ ... ] CPU 0 has 4294967295 vectors, 589 available. Cannot disable CPU
>
> And the problem seems to be that irq_matrix_assign()/irq_matrix_free() calls
> for PIC_CASCADE_IR are unbalanced, making cm->allocated go negative.
>
> RFC as I didn't quite get why we're making an exception for PIC_CASCADE_IR in
> the first place. Surely it is special, but for the sake of consistency we'd
> better not treat it as such. Or maybe I just misunderstood everything.
>
If the RFC part is the only thing which scares everyone off I'm ready to
drop it and pretend that I'm confident with the change)
> Vitaly Kuznetsov (2):
> x86/apic: Do not make an exception for PIC_CASCADE_IR when marking
> legacy irqs in irq_matrix
> genirq/matrix: WARN_ON_ONCE() when cm->allocated/m->total_allocated go
> negative
>
> arch/x86/kernel/apic/vector.c | 3 +--
> kernel/irq/matrix.c | 11 +++++++++--
> 2 files changed, 10 insertions(+), 4 deletions(-)
--
Vitaly
prev parent reply other threads:[~2021-03-11 10:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:30 [PATCH RFC 0/2] x86/apic: Avoid cm->allocated going negative in irq_matrix Vitaly Kuznetsov
2021-02-19 11:31 ` [PATCH RFC 1/2] x86/apic: Do not make an exception for PIC_CASCADE_IR when marking legacy irqs " Vitaly Kuznetsov
2021-03-17 20:14 ` Thomas Gleixner
2021-03-17 21:18 ` Thomas Gleixner
2021-03-17 21:40 ` Thomas Gleixner
2021-03-17 22:52 ` Thomas Gleixner
2021-03-18 8:47 ` Vitaly Kuznetsov
2021-03-18 8:29 ` Vitaly Kuznetsov
2021-03-18 10:10 ` Thomas Gleixner
2021-02-19 11:31 ` [PATCH RFC 2/2] genirq/matrix: WARN_ON_ONCE() when cm->allocated/m->total_allocated go negative Vitaly Kuznetsov
2021-03-17 20:38 ` Thomas Gleixner
2021-03-18 7:58 ` Vitaly Kuznetsov
2021-03-18 19:29 ` Thomas Gleixner
2021-03-19 9:59 ` Vitaly Kuznetsov
2021-03-11 10:19 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft129enb.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).