From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EDAC433FE for ; Thu, 10 Dec 2020 00:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E095239FD for ; Thu, 10 Dec 2020 00:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728426AbgLJAWR (ORCPT ); Wed, 9 Dec 2020 19:22:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbgLJAWR (ORCPT ); Wed, 9 Dec 2020 19:22:17 -0500 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FB87C0613CF for ; Wed, 9 Dec 2020 16:21:36 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4CrvjQ4CCFz9sWR; Thu, 10 Dec 2020 11:21:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1607559694; bh=gUZqycqRbXTyBxFOg8awmtGV88oSNS0vpFmP17hRE8I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iXVlNHV7UeasFgTcvPoOsDtvudLakpBzfGe/AodMrzWLe6r723U2AbOJKaPvvv7CY rCHNeEBRzlnTZqStVaQAbsyEv+pDNCUuBsko533qvj8TfG2p5gcg2XTofGs1v5rcZN Dn9i0TmnpAI6JubAMqDCkzjm7pE+xatB2SAo0EBlEuM0CaEFWbKn8SROn1iRJEAIJ6 AbTi1WWeOSOIUico+Q0SDITrF+vUggxyOOiWawqRXlUGtfCaVmxl+4FbAs6RyzUvRE uWP9xksLPBCG/ZwJM97i74ms5+I/AVrkJPcqN2LNXOUKWGn3WqbMG12MLmQs2N9Ed3 8JS1BtcWXh2hQ== From: Michael Ellerman To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 2/6] powerpc/8xx: Always pin kernel text TLB In-Reply-To: References: <203b89de491e1379f1677a2685211b7c32adfff0.1606231483.git.christophe.leroy@csgroup.eu> <87lfe7s1j3.fsf@mpe.ellerman.id.au> Date: Thu, 10 Dec 2020 11:21:29 +1100 Message-ID: <87ft4ese7q.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 09/12/2020 =C3=A0 11:43, Michael Ellerman a =C3=A9crit=C2=A0: >> Christophe Leroy writes: >>> There is no big poing in not pinning kernel text anymore, as now >>> we can keep pinned TLB even with things like DEBUG_PAGEALLOC. >>> >>> Remove CONFIG_PIN_TLB_TEXT, making it always right. >>> >>> Signed-off-by: Christophe Leroy >>> --- >>> arch/powerpc/Kconfig | 3 +-- >>> arch/powerpc/kernel/head_8xx.S | 20 +++----------------- >>> arch/powerpc/mm/nohash/8xx.c | 3 +-- >>> arch/powerpc/platforms/8xx/Kconfig | 7 ------- >>> 4 files changed, 5 insertions(+), 28 deletions(-) >>> >> ... >>> diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c >>> index 231ca95f9ffb..19a3eec1d8c5 100644 >>> --- a/arch/powerpc/mm/nohash/8xx.c >>> +++ b/arch/powerpc/mm/nohash/8xx.c >>> @@ -186,8 +186,7 @@ void mmu_mark_initmem_nx(void) >>> mmu_mapin_ram_chunk(0, boundary, PAGE_KERNEL_TEXT, false); >>> mmu_mapin_ram_chunk(boundary, einittext8, PAGE_KERNEL, false); >>>=20=20=20 >>> - if (IS_ENABLED(CONFIG_PIN_TLB_TEXT)) >>> - mmu_pin_tlb(block_mapped_ram, false); >>> + mmu_pin_tlb(block_mapped_ram, false); >>> } >>=20 >> This broke mpc885_ads_defconfig with: > > :surprise: > > How did I get it working ? Anyway, thanks for fixing it. No worries. I figured you must have tested with some other series(s) applied and/or with different configs, it happens :) cheers