From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 0/3] TTY improve n_gsm support
Date: Mon, 18 May 2020 12:01:45 +0200 [thread overview]
Message-ID: <87ftbxfto6.fsf@FE-laptop> (raw)
In-Reply-To: <20200518084517.2173242-4-gregory.clement@bootlin.com>
Hello,
> Hello,
>
> This series is the second version of patch improving n_gms support
> especially with TELIT LE910. However the fix should benefit to any
> modem supporting cmux.
You can just ignore the emails from this point, I forgot to remove the
remaining .patch!
Sorry for the noise
Gregory
>
> The first patch is just about improving debugging output.
>
> The second one removes a tty optimization which make the LE910 hang.
>
> The last one fixes an issue observed on the LE910 but should benefit
> to all the modem. We observed that pretty quickly the transfer done
> using the virtual tty were blocked. We found that it was due of a
> wakeup to the real tty. Without this fix, the real tty wait for
> indefinitely.
>
> Thanks to Jiri Slaby for the review.
>
> Changelog:
> v1 -> v2:
> - don't replace the pr_info by pr_debug
> - remove the superfluous printk("\n");
> - use --follow option with git log to find the original commit to fix
> - use tty_port_tty_wakeup
> - use 'for' loop instead of 'while'
>
> Gregory
>
> Gregory CLEMENT (3):
> tty: n_gsm: Improve debug output
> tty: n_gsm: Fix SOF skipping
> tty: n_gsm: Fix waking up upper tty layer when room available
>
> drivers/tty/n_gsm.c | 48 +++++++++++++++++++++++----------------------
> 1 file changed, 25 insertions(+), 23 deletions(-)
>
> --
> 2.26.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2020-05-18 10:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 8:45 [PATCH 0/2] TTY fix-ups for "TTY improve n_gsm support" series Gregory CLEMENT
2020-05-18 8:45 ` [PATCH 1/2] tty: n_gsm: Remove unnecessary test in gsm_print_packet() Gregory CLEMENT
2020-05-18 8:45 ` [PATCH 2/2] tty: n_gsm: Fix bogus i++ in gsm_data_kick Gregory CLEMENT
2020-05-18 8:45 ` [PATCH v2 0/3] TTY improve n_gsm support Gregory CLEMENT
2020-05-18 10:01 ` Gregory CLEMENT [this message]
2020-05-18 8:45 ` [PATCH v2 1/3] tty: n_gsm: Improve debug output Gregory CLEMENT
2020-05-18 8:45 ` [PATCH v2 2/3] tty: n_gsm: Fix SOF skipping Gregory CLEMENT
2020-05-18 8:45 ` [PATCH v2 3/3] tty: n_gsm: Fix waking up upper tty layer when room available Gregory CLEMENT
-- strict thread matches above, loose matches on Subject: below --
2020-05-12 11:53 [PATCH v2 0/3] TTY improve n_gsm support Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftbxfto6.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).