From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4707C43219 for ; Thu, 2 May 2019 03:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8917E21479 for ; Thu, 2 May 2019 03:30:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726304AbfEBDab (ORCPT ); Wed, 1 May 2019 23:30:31 -0400 Received: from ozlabs.org ([203.11.71.1]:56759 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbfEBDab (ORCPT ); Wed, 1 May 2019 23:30:31 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 44vgkq24r6z9s5c; Thu, 2 May 2019 13:30:27 +1000 (AEST) From: Michael Ellerman To: Christoph Hellwig , Oleg Nesterov , Arnd Bergmann Cc: x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] powerpc: don't use asm-generic/ptrace.h In-Reply-To: <20190501173943.5688-3-hch@lst.de> References: <20190501173943.5688-1-hch@lst.de> <20190501173943.5688-3-hch@lst.de> Date: Thu, 02 May 2019 13:30:26 +1000 Message-ID: <87ftpxa5yl.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > Doing the indirection through macros for the regs accessors just > makes them harder to read, so implement the helpers directly. > > Note that only the helpers actually used are implemented now. > > Signed-off-by: Christoph Hellwig > --- > arch/powerpc/include/asm/ptrace.h | 29 ++++++++++++++++++++++------- > 1 file changed, 22 insertions(+), 7 deletions(-) Looks fine, thanks. Acked-by: Michael Ellerman cheers > diff --git a/arch/powerpc/include/asm/ptrace.h b/arch/powerpc/include/asm/ptrace.h > index 64271e562fed..5d30944f1f6b 100644 > --- a/arch/powerpc/include/asm/ptrace.h > +++ b/arch/powerpc/include/asm/ptrace.h > @@ -108,18 +108,33 @@ struct pt_regs > > #ifndef __ASSEMBLY__ > > -#define GET_IP(regs) ((regs)->nip) > -#define GET_USP(regs) ((regs)->gpr[1]) > -#define GET_FP(regs) (0) > -#define SET_FP(regs, val) > +static inline unsigned long instruction_pointer(struct pt_regs *regs) > +{ > + return regs->nip; > +} > + > +static inline void instruction_pointer_set(struct pt_regs *regs, > + unsigned long val) > +{ > + regs->nip = val; > +} > + > +static inline unsigned long user_stack_pointer(struct pt_regs *regs) > +{ > + return regs->gpr[1]; > +} > + > +static inline unsigned long frame_pointer(struct pt_regs *regs) > +{ > + return 0; > +} > > #ifdef CONFIG_SMP > extern unsigned long profile_pc(struct pt_regs *regs); > -#define profile_pc profile_pc > +#else > +#define profile_pc(regs) instruction_pointer(regs) > #endif > > -#include > - > #define kernel_stack_pointer(regs) ((regs)->gpr[1]) > static inline int is_syscall_success(struct pt_regs *regs) > { > -- > 2.20.1