From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F69C43381 for ; Wed, 20 Feb 2019 13:23:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC33520880 for ; Wed, 20 Feb 2019 13:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbfBTNXP convert rfc822-to-8bit (ORCPT ); Wed, 20 Feb 2019 08:23:15 -0500 Received: from ozlabs.org ([203.11.71.1]:54231 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfBTNXP (ORCPT ); Wed, 20 Feb 2019 08:23:15 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 444JFX0zLHz9s1B; Thu, 21 Feb 2019 00:23:12 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Jonathan =?utf-8?Q?Neusch?= =?utf-8?Q?=C3=A4fer?= Cc: Benjamin Herrenschmidt , Paul Mackerras , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 00/15] powerpc/32s: Use BATs/LTLBs for STRICT_KERNEL_RWX In-Reply-To: <8b072209-c845-20f5-8ff1-27ecd67b5c72@c-s.fr> References: <20190113181621.GA22334@latitude> <714e78ba-1e92-a856-3dd6-a1fb96ad3785@c-s.fr> <20190113210227.GB22334@latitude> <334b1b02-b652-499c-904e-09e6f7164b8c@c-s.fr> <20190115003353.GD22334@latitude> <87fttuz0d3.fsf@concordia.ellerman.id.au> <8b072209-c845-20f5-8ff1-27ecd67b5c72@c-s.fr> Date: Thu, 21 Feb 2019 00:23:09 +1100 Message-ID: <87ftsi7fwi.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 15/01/2019 à 11:22, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Le 15/01/2019 à 01:33, Jonathan Neuschäfer a écrit : >> ... >>>> >>>> - patches 7 to 11 fail to build with this error (really a warning, but >>>> arch/powerpc doesn't allow warnings by default): >>>> >>>> CC arch/powerpc/mm/ppc_mmu_32.o >>>> ../arch/powerpc/mm/ppc_mmu_32.c:133:13: error: ‘clearibat’ defined but not used [-Werror=unused-function] >>>> static void clearibat(int index) >>>> ^~~~~~~~~ >>>> ../arch/powerpc/mm/ppc_mmu_32.c:115:13: error: ‘setibat’ defined but not used [-Werror=unused-function] >>>> static void setibat(int index, unsigned long virt, phys_addr_t phys, >>>> ^~~~~~~ >>>> cc1: all warnings being treated as errors >>> >>> Argh ! I have to squash the patch bringing the new functions with the >>> one using them (patch 12). The result is a big messy patch which is more >>> difficult to review but that's life. >> >> You don't *have* to squash them. >> >> We like to preserve bisectability, but it's not a 100% hard requirement. >> >> Someone trying to bisect through those patches can always turn off >> -Werror with PPC_DISABLE_WERROR. But they probably can just skip them >> because they just add new code that's not called yet. > > Ok thanks for the note. > >> >> So I won't object if you send them as-is. > > Good to know. Anyway I think I will at least re-order so that the patch > using the new functions immediatly follows the one adding the functions. Based on that I'm expecting a v3 of this series, right? cheers