From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe LEROY <christophe.leroy@c-s.fr>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
linux-kernel@vger.kernel.org
Cc: Alastair D'Silva <alastair@d-silva.org>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Cyril Bur <cyrilbur@gmail.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Joe Perches <joe@perches.com>,
Michael Neuling <mikey@neuling.org>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Simon Guo <wei.guo.simon@gmail.com>,
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
"Tobin C . Harding" <me@tobin.cc>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 9/9] powerpc/traps: Add line prefix in show_instructions()
Date: Thu, 02 Aug 2018 00:14:49 +1000 [thread overview]
Message-ID: <87ftzyfa1y.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <c7e0fe17-8c4e-4ccc-dadf-9b320ca5a1d2@c-s.fr>
Christophe LEROY <christophe.leroy@c-s.fr> writes:
> Le 31/07/2018 à 16:50, Murilo Opsfelder Araujo a écrit :
>> Remove "Instruction dump:" line by adding a prefix to display current->comm
>> and current->pid, along with the instructions dump.
>>
>> The prefix can serve as a glue that links the instructions dump to its
>> originator, allowing messages to be interleaved in the logs.
>>
>> Before this patch, a page fault looked like:
>>
>> pandafault[10524]: segfault (11) at 100007d0 nip 1000061c lr 7fffbd295100 code 2 in pandafault[10000000+10000]
>> Instruction dump:
>> 4bfffeec 4bfffee8 3c401002 38427f00 fbe1fff8 f821ffc1 7c3f0b78 3d22fffe
>> 392988d0 f93f0020 e93f0020 39400048 <99490000> 39200000 7d234b78 383f0040
>>
>> After this patch, it looks like:
>>
>> pandafault[10850]: segfault (11) at 100007d0 nip 1000061c lr 7fff9f3e5100 code 2 in pandafault[10000000+10000]
>> pandafault[10850]: code: 4bfffeec 4bfffee8 3c401002 38427f00 fbe1fff8 f821ffc1 7c3f0b78 3d22fffe
>> pandafault[10850]: code: 392988d0 f93f0020 e93f0020 39400048 <99490000> 39200000 7d234b78 383f0040
>>
>> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
>
> Does the script scripts/decode_stacktrace.sh also works with this format
> change ?
Did it work before? I've never used it.
Would be great if it did work though.
cheers
next prev parent reply other threads:[~2018-08-01 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 14:50 [PATCH v3 0/9] powerpc: Modernize unhandled signals message Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 1/9] powerpc/traps: Print unhandled signals in a separate function Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 2/9] powerpc/traps: Return early in show_signal_msg() Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 3/9] powerpc/traps: Use %lx format " Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 4/9] powerpc/traps: Print VMA for unhandled signals Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 5/9] powerpc/traps: Print signal name " Murilo Opsfelder Araujo
2018-08-01 6:37 ` Christophe LEROY
2018-08-01 7:03 ` Joe Perches
2018-08-01 7:49 ` Segher Boessenkool
2018-08-01 14:44 ` Murilo Opsfelder Araujo
2018-08-01 14:42 ` Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 6/9] powerpc: Do not call __kernel_text_address() in show_instructions() Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 7/9] powerpc: Add stacktrace.h header Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 8/9] powerpc/traps: Show instructions on exceptions Murilo Opsfelder Araujo
2018-07-31 14:50 ` [PATCH v3 9/9] powerpc/traps: Add line prefix in show_instructions() Murilo Opsfelder Araujo
2018-08-01 6:41 ` Christophe LEROY
2018-08-01 14:14 ` Michael Ellerman [this message]
2018-08-01 15:03 ` Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftzyfa1y.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=alastair@d-silva.org \
--cc=andrew.donnellan@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=cyrilbur@gmail.com \
--cc=ebiederm@xmission.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=me@tobin.cc \
--cc=mikey@neuling.org \
--cc=muriloo@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).