From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934198AbeALRid (ORCPT + 1 other); Fri, 12 Jan 2018 12:38:33 -0500 Received: from out03.mta.xmission.com ([166.70.13.233]:46989 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932859AbeALRib (ORCPT ); Fri, 12 Jan 2018 12:38:31 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Stafford Horne Cc: linux-kernel@vger.kernel.org, Al Viro , Oleg Nesterov , linux-arch@vger.kernel.org, stable@vger.kernel.org, Jonas Bonn , Stefan Kristiansson , Arnd Bergmann , openrisc@lists.librecores.org References: <87373b6ghs.fsf@xmission.com> <20180112005940.23279-3-ebiederm@xmission.com> <20180112132521.GF13019@lianli.shorne-pla.net> Date: Fri, 12 Jan 2018 11:37:40 -0600 In-Reply-To: <20180112132521.GF13019@lianli.shorne-pla.net> (Stafford Horne's message of "Fri, 12 Jan 2018 22:25:21 +0900") Message-ID: <87fu7b2d23.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1ea3Hg-0000Tv-16;;;mid=<87fu7b2d23.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.121.73.102;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/qeh3gKjiIlUsO8IEmSSgf3dJ3907ZRPM= X-SA-Exim-Connect-IP: 97.121.73.102 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 03/11] signal/openrisc: Fix do_unaligned_access to send the proper signal X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Stafford Horne writes: > On Thu, Jan 11, 2018 at 06:59:32PM -0600, Eric W. Biederman wrote: >> While reviewing the signal sending on openrisc the do_unaligned_access >> function stood out because it is obviously wrong. A comment about an >> si_code set above when actually si_code is never set. Leading to a >> random si_code being sent to userspace in the event of an unaligned >> access. >> >> Looking further SIGBUS BUS_ADRALN is the proper pair of signal and >> si_code to send for an unaligned access. That is what other >> architectures do and what is required by posix. >> >> Given that do_unaligned_access is broken in a way that no one can be >> relying on it on openrisc fix the code to just do the right thing. > > Thanks, this looks good to me. > > Acked-by: Stafford Horne > > I see you have a series of related issues, so I guess you want to get them > merged together. Let me know if I should put this patch onto my queue > seperately. Yes, I have a follow on patch that restructures the code that fills out siginfo, and makes the it a little less error prone. I am hoping to merge all of it in the next merge window. *Fingers crossed* And having it all in one tree will facilitate that. > Trivia: this looks to have been copied from the mm page fault handling code, > hence the strange comment. > > $ grep -r "info.si_code has been set above" arch/ > arch/cris/mm/fault.c: /* info.si_code has been set above */ > arch/m32r/mm/fault.c: /* info.si_code has been set above */ > arch/mn10300/mm/fault.c: /* info.si_code has been set above */ > arch/openrisc/mm/fault.c: /* info.si_code has been set above */ > arch/openrisc/kernel/traps.c: /* info.si_code has been set above */ > arch/arc/mm/fault.c: /* info.si_code has been set above */ > arch/xtensa/mm/fault.c: /* info.si_code has been set above */ > arch/mips/mm/fault.c: /* info.si_code has been set above */ > arch/score/mm/fault.c: /* info.si_code has been set above */ > arch/frv/mm/fault.c: /* info.si_code has been set above */ > It looks like it. When I look at those I can actually find the si_code being set higher up in the code. It looks like the si_code value was missed when this work was done. Eric