From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932819AbcFOV57 (ORCPT ); Wed, 15 Jun 2016 17:57:59 -0400 Received: from anholt.net ([50.246.234.109]:53553 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbcFOV55 (ORCPT ); Wed, 15 Jun 2016 17:57:57 -0400 From: Eric Anholt To: Catalin Marinas Cc: linux-rpi-kernel@lists.infradead.org, Will Deacon , open list , linux-arm-kernel@lists.infradead.org, Gerd Hoffmann Subject: Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835. In-Reply-To: <20160615080730.GA18868@e104818-lin.cambridge.arm.com> References: <1464934708-24769-1-git-send-email-kraxel@redhat.com> <1464934708-24769-5-git-send-email-kraxel@redhat.com> <20160603112721.GC1128@e104818-lin.cambridge.arm.com> <87bn3gu3to.fsf@eliezer.anholt.net> <20160608091219.GA16322@e104818-lin.cambridge.arm.com> <87h9d1x59s.fsf@eliezer.anholt.net> <20160610095633.GA14961@e104818-lin.cambridge.arm.com> <87d1njq755.fsf@eliezer.anholt.net> <20160615080730.GA18868@e104818-lin.cambridge.arm.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 15 Jun 2016 14:57:47 -0700 Message-ID: <87fuse9ktg.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Catalin Marinas writes: > On Tue, Jun 14, 2016 at 11:48:54PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >>=20 >> > On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote: >> >> Catalin Marinas writes: >> >> > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote: >> >> >> Catalin Marinas writes: >> >> >> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote: >> >> >> >> + This SoC is used in the Raspberry Pi 3 device. >> >> >> > >> >> >> > I thought we would just use ARCH_BCM, or is it too generic? >> >> >>=20 >> >> >> Consensus last time around seemed to be to drop adding ARCH_BCM, in >> >> >> favor of patch 1 of the series. >> >> > >> >> > I may have missed that discussion. My point was about consistency w= ith >> >> > existing ARCH_* definitions in the arm64 Kconfig.platforms. I can s= ee >> >> > why it's easier for you since some drivers are built based on >> >> > ARCH_BCM2835. Looking at drivers/clk/bcm/Makefile, there is an >> >> > inconsistent mix of CLK_BCM_* and ARCH_BCM_*. I would rather have a= new >> >> > CLK_BCM2835 that's selected/enabled accordingly (maybe simply depen= ding >> >> > on ARCH_BCM). >> >>=20 >> >> So I introduce a new ARCH_BCM here, that selects the just the 283x >> >> family's core drivers? That seems strange, but I'm willing if that's >> >> what you want. >> > >> > I'll leave this decision to the arm-soc guys. What I want to avoid is >> > another ARCH_BCM283[89] when some clock or other device changes in a >> > future revision of this board (RPi4?). I also don't want fine-grained >> > SoC configuration *within* the arch/arm64 Kconfigs but rather just a >> > family ARCH_* entry with selectable individual drivers based on the SoC >> > revision you target (in case you want to avoid single Image). >> > >> > We should in general try to give drivers their own Kconfig entries >> > separate from ARCH_* ones (with a "depend on ARCH_*" and default y if >> > you want it enabled). >>=20 >> OK, we haven't added separate ARCH_BCM283* for the 3 chip revs so far, >> so I think what you want is actually the status quo, and we're in >> serious agreement. The name for the family just happens to be >> ARCH_BCM2835. >>=20 >> Any chance we could get an ack on this? > > If you need one ;) (arm-soc is maintaining this file): > > Acked-by: Catalin Marinas It's in my for-next now. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXYc9cAAoJELXWKTbR/J7oDvEP/0dfkJ/iNwr/Ac0XRMHIF01H RhFg1jXQD+huqDb5+PFo48IKPA69EYlpbRODDDDa5eORTQBnFRzpWJ8tnWfY7+36 U3N/CqVg9/vlYOqAaqIlcPY0Adhbom+YLQtJPOep6Yc9e4VQnmUCICOJbeRFzj5D h8MWWgJQsUA6jB2UXaurpELcy/CVLycJ39abglxE4fim/YNUkjIbsTxrSbSpn9Er FzIeFDOyCmejMe5IWEilK4rRuDvuYOjTdE/EpY3pDHu6C9pSV8JvJzd4mdGWeyQj wdUxIFmgI3szERNJt6+cBMmYsJlxtl5DWdE5liGRspBiJDVGPLO5tyHulYESC0x0 wJWdUX+aieRWwQIwEXj+WbmrB49xf+e8auzRvL2Ebg06Jaxifrc1aY5Zy5GWU738 0Hs1Ve5+kTduRKMGjbB3QDYMuKZ+PzI0Y41HetfzcHdKAn6J8/6gtz3cVeId9CYI m3WqskSfFx7WiVdUlOggZdxG1D4fRuHbcA4CvJWXhmWFpEfeB+UqBNYEHNhwo3l/ wvyaPpMiS0s1IDvlcVdjxQeLK5zcs9VQteDQDvY1xRBSmeUFqv3unV5e0Ujr3WAC H3NwJmWYDGmB21o11+fBrIlLDlNNjovDpIQ+eLVUTvuExiijnmRfScvkdnuoI99X 1/lKNZA1i9kiFG3ehYGX =1Mrf -----END PGP SIGNATURE----- --=-=-=--