From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756783Ab2ARDPX (ORCPT ); Tue, 17 Jan 2012 22:15:23 -0500 Received: from ozlabs.org ([203.10.76.45]:44046 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755151Ab2ARDPW (ORCPT ); Tue, 17 Jan 2012 22:15:22 -0500 From: Rusty Russell To: Olof Johansson Cc: Kay Sievers , linux-kernel@vger.kernel.org Subject: Re: [PATCH] modules: fix build error with !CONFIG_MODULE_UNLOAD In-Reply-To: References: <1326673943-26105-1-git-send-email-olof@lixom.net> <87aa5nhohv.fsf@rustcorp.com.au> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Wed, 18 Jan 2012 13:26:47 +1030 Message-ID: <87fwfdzpjk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jan 2012 22:23:32 -0800, Olof Johansson wrote: > On Mon, Jan 16, 2012 at 3:32 AM, Rusty Russell wrote: > > On Sun, 15 Jan 2012 16:32:23 -0800, Olof Johansson wrote: > >> Looks like the "module_flags_taint" helper was added under an #ifdef > >> CONFIG_MODULE_UNLOAD block, move it out of it. > >> > >> Fixes: > >> > >> kernel/module.c: In function 'show_taint': > >> kernel/module.c:1024:2: error: implicit declaration of function 'module_flags_taint' > >> > >> Signed-off-by: Olof Johansson > > > > Applied. > > > It looks like Linus already took an equivalent patch (shortly after I > had sent mine). You can drop it to avoid conflicts. Indeed, I dropped it when I re-synced. Thanks, Rusty.