From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
Maxime Ripard <mripard@kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Emma Anholt <emma@anholt.net>, Karol Herbst <kherbst@redhat.com>,
Samuel Holland <samuel@sholland.org>,
Daniel Vetter <daniel@ffwll.ch>, Lyude Paul <lyude@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
nouveau@lists.freedesktop.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Phil Elwell" <phil@raspberrypi.com>,
intel-gfx@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Dom Cobley" <dom@raspberrypi.com>,
linux-sunxi@lists.linux.dev,
"Mateusz Kwiatkowski" <kfyatek+publicgit@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes
Date: Fri, 23 Sep 2022 12:18:32 +0300 [thread overview]
Message-ID: <87h70y4ffb.fsf@intel.com> (raw)
In-Reply-To: <72a8c3ce-ed03-0a77-fb92-eaa992eb86fe@suse.de>
On Fri, 23 Sep 2022, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 22.09.22 um 16:25 schrieb Maxime Ripard:
>> + drm_dbg_kms(dev,
>> + "Generating a %ux%u%c, %u-line mode with a %lu kHz clock\n",
>> + hactive, vactive,
>> + interlace ? 'i' : 'p',
>> + params->num_lines,
>> + pixel_clock_hz / 1000);
>
> Divide by HZ_PER_KHZ here and in other places.
>
> https://elixir.bootlin.com/linux/latest/source/include/linux/units.h#L23
From the Department of Bikeshedding:
I find "pixel_clock_hz / 1000" has much more clarity than
"pixel_clock_hz / HZ_PER_KHZ".
I don't consider the SI prefixes magic numbers.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-09-23 9:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech>
2022-09-22 14:31 ` [PATCH v2 00/33] drm: Analog TV Improvements Maxime Ripard
[not found] ` <20220728-rpi-analog-tv-properties-v2-6-f733a0ed9f90@cerno.tech>
2022-09-22 20:44 ` [PATCH v2 06/33] drm/connector: Rename legacy TV property Lyude Paul
2022-09-23 8:19 ` Thomas Zimmermann
2022-09-26 9:50 ` Maxime Ripard
2022-09-26 12:34 ` Thomas Zimmermann
2022-09-24 15:38 ` Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-1-f733a0ed9f90@cerno.tech>
2022-09-23 8:06 ` [PATCH v2 01/33] drm/tests: Order Kunit tests in Makefile Thomas Zimmermann
2022-09-24 17:33 ` Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-3-f733a0ed9f90@cerno.tech>
2022-09-23 8:09 ` [PATCH v2 03/33] drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity Thomas Zimmermann
[not found] ` <20220728-rpi-analog-tv-properties-v2-4-f733a0ed9f90@cerno.tech>
2022-09-23 8:14 ` [PATCH v2 04/33] drm/connector: Rename subconnector state variable Thomas Zimmermann
[not found] ` <20220728-rpi-analog-tv-properties-v2-10-f733a0ed9f90@cerno.tech>
2022-09-23 9:05 ` [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes Thomas Zimmermann
2022-09-23 9:18 ` Jani Nikula [this message]
2022-09-23 10:16 ` Thomas Zimmermann
2022-09-26 10:18 ` Maxime Ripard
2022-09-26 10:55 ` Thomas Zimmermann
2022-09-26 10:17 ` Maxime Ripard
2022-09-26 10:34 ` Geert Uytterhoeven
2022-09-26 11:17 ` Thomas Zimmermann
2022-09-26 12:42 ` Maxime Ripard
2022-09-26 13:02 ` Thomas Zimmermann
[not found] ` <20220728-rpi-analog-tv-properties-v2-13-f733a0ed9f90@cerno.tech>
2022-09-23 9:15 ` [PATCH v2 13/33] drm/client: Add some tests for drm_connector_pick_cmdline_mode() Thomas Zimmermann
2022-09-23 9:26 ` Javier Martinez Canillas
2022-09-23 10:30 ` Thomas Zimmermann
2022-09-23 11:01 ` Javier Martinez Canillas
2022-09-23 11:14 ` Maxime Ripard
2022-09-23 11:59 ` Jani Nikula
[not found] ` <20220728-rpi-analog-tv-properties-v2-8-f733a0ed9f90@cerno.tech>
2022-09-22 20:45 ` [PATCH v2 08/33] drm/connector: Rename drm_mode_create_tv_properties Lyude Paul
2022-09-24 15:43 ` Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-9-f733a0ed9f90@cerno.tech>
2022-09-24 15:52 ` [PATCH v2 09/33] drm/connector: Add TV standard property Noralf Trønnes
2022-09-26 10:01 ` Maxime Ripard
2022-09-26 12:59 ` Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-27-f733a0ed9f90@cerno.tech>
2022-09-24 15:58 ` [PATCH v2 27/33] drm/atomic-helper: Add an analog TV atomic_check implementation Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-28-f733a0ed9f90@cerno.tech>
2022-09-24 15:59 ` [PATCH v2 28/33] drm/vc4: vec: Fix definition of PAL-M mode Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-30-f733a0ed9f90@cerno.tech>
2022-09-24 16:00 ` [PATCH v2 30/33] drm/vc4: vec: Check for VEC output constraints Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-31-f733a0ed9f90@cerno.tech>
2022-09-24 17:09 ` [PATCH v2 31/33] drm/vc4: vec: Convert to the new TV mode property Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-32-f733a0ed9f90@cerno.tech>
2022-09-24 17:12 ` [PATCH v2 32/33] drm/vc4: vec: Add support for more analog TV standards Noralf Trønnes
[not found] ` <20220728-rpi-analog-tv-properties-v2-2-f733a0ed9f90@cerno.tech>
2022-09-24 17:56 ` [PATCH v2 02/33] drm/tests: Add Kunit Helpers Noralf Trønnes
2022-09-24 18:06 ` Noralf Trønnes
2022-09-26 9:36 ` Maxime Ripard
2022-09-26 12:15 ` Noralf Trønnes
2022-09-25 15:58 ` [PATCH v2 00/33] drm: Analog TV Improvements Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h70y4ffb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kfyatek+publicgit@gmail.com \
--cc=kherbst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phil@raspberrypi.com \
--cc=rodrigo.vivi@intel.com \
--cc=samuel@sholland.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).