[PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting

[PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting

[Yang Li]

Eliminate the follow smatch warning:
drivers/net/wireless/ath/wcn36xx/smd.c:3151
wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 872b37875c57..691e637b94f1 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -3148,9 +3148,9 @@ static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
 			cpu_to_le64(rsp->key_replay_counter);
 		ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
 					   (void *)&replay_ctr, GFP_KERNEL);
-		 wcn36xx_dbg(WCN36XX_DBG_HAL,
-			     "GTK replay counter increment %llu\n",
-			     rsp->key_replay_counter);
+		wcn36xx_dbg(WCN36XX_DBG_HAL,
+			    "GTK replay counter increment %llu\n",
+			    rsp->key_replay_counter);
 	}
 
 	wcn36xx_dbg(WCN36XX_DBG_HAL,
-- 
2.20.1.7.g153144c

[PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()

[Yang Li]

The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant
because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/wireless/ath/ath9k/ahb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index c9b853af41d1..9cd12b20b18d 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -99,10 +99,8 @@ static int ath_ahb_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "no IRQ resource found\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	ath9k_fill_chanctx_ops();
 	hw = ieee80211_alloc_hw(sizeof(struct ath_softc), &ath9k_ops);
-- 
2.20.1.7.g153144c

Re: [PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting

[Loic Poulain]

On Fri, 8 Apr 2022 at 02:01, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Eliminate the follow smatch warning:
> drivers/net/wireless/ath/wcn36xx/smd.c:3151
> wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Acked-by: Loic Poulain <loic.poulain@linaro.org>

Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()

[Toke Høiland-Jørgensen]

Yang Li <yang.lee@linux.alibaba.com> writes:

> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Heh, so I was the one originally insisting on keeping that err print,
but looking a bit closer now it does really appear to be redundant, so:

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>

Re: [PATCH -next 1/2] wcn36xx: clean up some inconsistent indenting

[Kalle Valo]

Yang Li <yang.lee@linux.alibaba.com> wrote:

> Eliminate the follow smatch warning:
> drivers/net/wireless/ath/wcn36xx/smd.c:3151
> wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Acked-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

2578171ff85e wcn36xx: clean up some inconsistent indenting

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220408000113.129906-1-yang.lee@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()

[Kalle Valo]

Yang Li <yang.lee@linux.alibaba.com> wrote:

> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> Eliminate the follow coccicheck warning:
> ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant
> because platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

d7ceee8051ba ath9k: Remove unnecessary print function dev_err()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220408000113.129906-2-yang.lee@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches