From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404AAC433EF for ; Tue, 30 Nov 2021 09:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231230AbhK3JtQ (ORCPT ); Tue, 30 Nov 2021 04:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233009AbhK3JtM (ORCPT ); Tue, 30 Nov 2021 04:49:12 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E7FDC061574; Tue, 30 Nov 2021 01:45:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BE3E2CE188C; Tue, 30 Nov 2021 09:45:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF322C53FC7; Tue, 30 Nov 2021 09:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638265549; bh=Ggg5Q95Lu9hc/6Oo5FScAmVRBJNCnZ2SWaDiu2bMZxk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f6k8DZdPZx9+szDTwTmzUBHbkVd9XrB6UdSE9As8vXvXo5jPRvWeeMQsv3t32w88n 8OKJKn1bWHIMO7YhxizHMZsm1fVg3Dq2QEax3WJf/0EZs4Zfh1Rlpsao3bGSQzAnoI w78GEcOd5Xq0RmEfwp8CjBqvNqs07PFd3peo8l9giVXX/HZ0MH1y8GEVa4/F3aIYCo k5oVNpopWu+Erj7Tbr/MUnTpQ0MxtJkc6vjZ+2OVYcjfnSLcnH/ibX8F+OrqL0tcpy ta6xhOXwJesJtY9LoqFzzfzhagYWEmTXoynwZGmo4BPKLN+DVCTiFFrYl30tuJLzTy /Q96UVxW5EqMA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mrzhr-008pbj-Ru; Tue, 30 Nov 2021 09:45:48 +0000 Date: Tue, 30 Nov 2021 09:45:46 +0000 Message-ID: <87h7bum0xh.wl-maz@kernel.org> From: Marc Zyngier To: Darren Hart Cc: Tyler Baicar , patches@amperecomputing.com, abdulhamid@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, mark.rutland@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, tabba@google.com, marcan@marcan.st, keescook@chromium.org, masahiroy@kernel.org, samitolvanen@google.com, john.garry@huawei.com, daniel.lezcano@linaro.org, gor@linux.ibm.com, zhangshaokun@hisilicon.com, tmricht@linux.ibm.com, dchinner@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, ishii.shuuichir@fujitsu.com, Vineeth.Pillai@microsoft.com Subject: Re: [PATCH 1/2] ACPI/AEST: Initial AEST driver In-Reply-To: References: <20211124170708.3874-1-baicar@os.amperecomputing.com> <20211124170708.3874-2-baicar@os.amperecomputing.com> <87czmpcto5.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: darren@os.amperecomputing.com, baicar@os.amperecomputing.com, patches@amperecomputing.com, abdulhamid@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, mark.rutland@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, tabba@google.com, marcan@marcan.st, keescook@chromium.org, masahiroy@kernel.org, samitolvanen@google.com, john.garry@huawei.com, daniel.lezcano@linaro.org, gor@linux.ibm.com, zhangshaokun@hisilicon.com, tmricht@linux.ibm.com, dchinner@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, ishii.shuuichir@fujitsu.com, Vineeth.Pillai@microsoft.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Darren, On Mon, 29 Nov 2021 20:39:23 +0000, Darren Hart wrote: > > On Wed, Nov 24, 2021 at 06:09:14PM +0000, Marc Zyngier wrote: > > On Wed, 24 Nov 2021 17:07:07 +0000, > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 5250298d2817..aa0483726606 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -382,6 +382,7 @@ ACPI FOR ARM64 (ACPI/arm64) > > > M: Lorenzo Pieralisi > > > M: Hanjun Guo > > > M: Sudeep Holla > > > +R: Tyler Baicar > > > L: linux-acpi@vger.kernel.org > > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > > > S: Maintained > > > > Isn't this a bit premature? This isn't even mentioned in the commit > > message, only in passing in the cover letter. > > > > Hi Marc, > > This was something I encouraged Tyler to add during internal review, > both in response to the checkpatch.pl warning about adding new drivers > as well as our interest in reviewing any future changes to the aest > driver. Since refactoring is common, this level made sense to me - but > would it be preferable to add a new entry for just the new driver Tyler > added? Adding someone as the co-maintainer/co-reviewer of a whole subsystem (ACPI/arm64 in this case) comes, IMO, with a number of pre-requisites: has the proposed co-{maintainer,reviewer} contributed and/or reviewed a significant number of patches to that subsystem and/or actively participated in the public discussions on the design and the maintenance of the subsystem, so that their reviewing is authoritative enough? I won't be judge of this, but it is definitely something to consider. I don't think preemptively adding someone to the MAINTAINERS entry to indicate an interest in a whole subsystem is the right way to do it. One could argue that this is what a mailing list is for! ;-) On the other hand, an active participation to the review process is the perfect way to engage with fellow developers and to grow a profile. It is at this stage that adding oneself as an upstream reviewer makes a lot of sense. Alternatively, adding a MAINTAINERS entry for a specific driver is definitely helpful and will certainly result in the listed maintainer to be Cc'd on changes affecting it. But I would really like this maintainer to actively engage with upstream, rather than simply be on the receiving end of a stream of changes. Thanks, M. -- Without deviation from the norm, progress is not possible.