From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc: <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
<Alexander.Deucher@amd.com>, <Sunil-kumar.Dommati@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Ravulapati Vishnu vardhan rao"
<Vishnuvardhanrao.Ravulapati@amd.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 12/12] ASoC: amd: enable vangogh acp5x driver build
Date: Fri, 16 Jul 2021 13:36:51 -0400 [thread overview]
Message-ID: <87h7guduto.fsf@collabora.com> (raw)
In-Reply-To: <20210716150809.21450-13-vijendar.mukunda@amd.com> (Vijendar Mukunda's message of "Fri, 16 Jul 2021 20:38:09 +0530")
Hi,
Vijendar Mukunda <vijendar.mukunda@amd.com> writes:
> Vangogh ACP5x drivers can be built by selecting necessary
> kernel config option.
> The patch enables build support of the same.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> v1 -> v2: remove extra line in Make file
> ---
> sound/soc/amd/Kconfig | 9 +++++++++
> sound/soc/amd/Makefile | 1 +
> sound/soc/amd/vangogh/Makefile | 11 +++++++++++
> 3 files changed, 21 insertions(+)
> create mode 100644 sound/soc/amd/vangogh/Makefile
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index ba5a85bf7412..cc48d4e5b080 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -52,3 +52,12 @@ config SND_SOC_AMD_RENOIR_MACH
> depends on SND_SOC_AMD_RENOIR
> help
> This option enables machine driver for DMIC
> +
> +config SND_SOC_AMD_ACP5x
> + tristate "AMD Audio Coprocessor-v5.x I2S support"
> + depends on X86 && PCI
> + help
> + This option enables ACP v5.x support on AMD platform
> +
> + By enabling this flag build will trigger for ACP PCI driver,
> + ACP DMA drvier, CPU DAI driver.
> diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
> index e6df2f72a2a1..07150d26f315 100644
> --- a/sound/soc/amd/Makefile
> +++ b/sound/soc/amd/Makefile
> @@ -10,3 +10,4 @@ obj-$(CONFIG_SND_SOC_AMD_CZ_RT5645_MACH) += snd-soc-acp-rt5645-mach.o
> obj-$(CONFIG_SND_SOC_AMD_ACP3x) += raven/
> obj-$(CONFIG_SND_SOC_AMD_RV_RT5682_MACH) += snd-soc-acp-rt5682-mach.o
> obj-$(CONFIG_SND_SOC_AMD_RENOIR) += renoir/
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
> diff --git a/sound/soc/amd/vangogh/Makefile b/sound/soc/amd/vangogh/Makefile
> new file mode 100644
> index 000000000000..ae2cda804e2f
> --- /dev/null
> +++ b/sound/soc/amd/vangogh/Makefile
> @@ -0,0 +1,11 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +# Vangogh platform Support
> +snd-pci-acp5x-objs := pci-acp5x.o
> +snd-acp5x-i2s-objs := acp5x-i2s.o
> +snd-acp5x-pcm-dma-objs := acp5x-pcm-dma.o
> +snd-soc-acp5x-mach-objs := acp5x-nu8821-cs35l41.o
> +
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-pci-acp5x.o
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-i2s.o
> +obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-pcm-dma.o
> +obj-$(CONFIG_SND_SOC_AMD_VANGOGH_MACH) += snd-soc-acp5x-mach.o
Looks like CONFIG_SND_SOC_AMD_VANGOGH_MACH is not selected by another
symbol and also not configurable in kconfig.
Is it missing a kconfig entry?
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2021-07-16 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210716150809.21450-1-vijendar.mukunda@amd.com>
2021-07-16 15:07 ` [PATCH 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda
2021-07-16 15:07 ` [PATCH V2 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 03/12] ASoc: amd: add acp5x init/de-init functions Vijendar Mukunda
2021-07-16 15:08 ` [PATCH 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda
2021-07-16 15:08 ` [PATCH v2 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 11/12] ASoC: amd: add vangogh i2s dma " Vijendar Mukunda
2021-07-16 15:08 ` [PATCH V2 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda
2021-07-16 17:36 ` Gabriel Krisman Bertazi [this message]
2021-07-16 18:00 ` Gabriel Krisman Bertazi
2021-07-17 3:42 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7guduto.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=Alexander.Deucher@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).