From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Arvind Sankar <nivedita@alum.mit.edu>,
Collabora Kernel ML <kernel@collabora.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning
Date: Fri, 13 Nov 2020 13:59:48 +0200 [thread overview]
Message-ID: <87h7ptjwln.fsf@collabora.com> (raw)
In-Reply-To: <CAMj1kXHQ94ZzoSUg6U70FnRtFs0KeVXT=Zg6ri2+OU_TKQcGfg@mail.gmail.com>
On Fri, 13 Nov 2020, Ard Biesheuvel <ardb@kernel.org> wrote:
> On Fri, 13 Nov 2020 at 12:05, Adrian Ratiu
> <adrian.ratiu@collabora.com> wrote:
>>
>> Hi Ard,
>>
>> On Fri, 13 Nov 2020, Ard Biesheuvel <ardb@kernel.org> wrote:
>> > On Thu, 12 Nov 2020 at 22:23, Adrian Ratiu
>> > <adrian.ratiu@collabora.com> wrote:
>> >>
>> >> From: Nathan Chancellor <natechancellor@gmail.com>
>> >>
>> >> Drop warning because kernel now requires GCC >= v4.9 after
>> >> commit 6ec4476ac825 ("Raise gcc version requirement to
>> >> 4.9").
>> >>
>> >> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
>> >> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>> >> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
>> >
>> > Again, this does not do what it says on the tin.
>> >
>> > If you want to disable the pragma for Clang, call that out in
>> > the commit log, and don't hide it under a GCC version change.
>>
>> I am not doing anything for Clang in this series.
>>
>> The option to auto-vectorize in Clang is enabled by default but
>> doesn't work for some reason (likely to do with how it computes
>> the cost model, so maybe not even a bug at all) and if we
>> enable it explicitely (eg via a Clang specific pragma) we get
>> some warnings we currently do not understand, so I am not
>> changing the Clang behaviour at the recommendation of Nick.
>>
>> So this is only for GCC as the "tin" says :) We can fix clang
>> separately as the Clang bug has always been present and is
>> unrelated.
>>
>
> But you are adding the IS_GCC check here, no? Is that
> equivalent? IOW, does Clang today identify as GCC <= 4.6?
>
I see what you mean now. Thanks.
Clang identifies as GCC <= 4.6 yes, so the code is not strictly
speaking equivalent. The warning to upgrade GCC doesn't make sense
for Clang but I should mention removing it in the commit message
as well.
>> >
>> > Without the pragma, the generated code is the same as the
>> > generic code, so it makes no sense to build xor-neon.ko at all,
>> > right?
>> >
>>
>> Yes that is correct and that is the reason why in v1 I opted to
>> not build xor-neon.ko for Clang anymore, but that got NACKed, so
>> here I'm fixing the low hanging fruit: the very obvious & clear
>> GCC problems.
>>
>>
>
> Fair enough.
>
>> >> ---
>> >> arch/arm/lib/xor-neon.c | 9 +--------
>> >> 1 file changed, 1 insertion(+), 8 deletions(-)
>> >>
>> >> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c
>> >> index b99dd8e1c93f..e1e76186ec23 100644
>> >> --- a/arch/arm/lib/xor-neon.c
>> >> +++ b/arch/arm/lib/xor-neon.c
>> >> @@ -19,15 +19,8 @@ MODULE_LICENSE("GPL");
>> >> * -ftree-vectorize) to attempt to exploit implicit parallelism and emit
>> >> * NEON instructions.
>> >> */
>> >> -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
>> >> +#ifdef CONFIG_CC_IS_GCC
>> >> #pragma GCC optimize "tree-vectorize"
>> >> -#else
>> >> -/*
>> >> - * While older versions of GCC do not generate incorrect code, they fail to
>> >> - * recognize the parallel nature of these functions, and emit plain ARM code,
>> >> - * which is known to be slower than the optimized ARM code in asm-arm/xor.h.
>> >> - */
>> >> -#warning This code requires at least version 4.6 of GCC
>> >> #endif
>> >>
>> >> #pragma GCC diagnostic ignored "-Wunused-variable"
>> >> --
>> >> 2.29.2
>> >>
next prev parent reply other threads:[~2020-11-13 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 21:24 [PATCH v2 0/2] xor-neon: Remove GCC warn & pragmas Adrian Ratiu
2020-11-12 21:24 ` [PATCH v2 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning Adrian Ratiu
2020-11-12 21:38 ` Nick Desaulniers
2020-11-13 7:49 ` Ard Biesheuvel
2020-11-13 11:07 ` Adrian Ratiu
2020-11-13 11:41 ` Ard Biesheuvel
2020-11-13 11:59 ` Adrian Ratiu [this message]
2020-11-12 21:24 ` [PATCH v2 2/2] arm: lib: xor-neon: move pragma options to makefile Adrian Ratiu
2020-11-12 21:40 ` Nick Desaulniers
2020-11-12 21:50 ` Nathan Chancellor
2020-11-13 7:50 ` Ard Biesheuvel
2020-11-13 11:17 ` Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7ptjwln.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).