LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	kernel test robot <rong.a.chen@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Jann Horn <jannh@google.com>, LKML <linux-kernel@vger.kernel.org>,
	x86-ml <x86@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	Borislav Petkov <bp@suse.de>,
	lkp@lists.01.org
Subject: Re: [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression
Date: Sun, 08 Mar 2020 19:07:17 +0100
Message-ID: <87h7yy90ve.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAHk-=whrpL8pbKLg3_s3+bxv6kbPnzbSP8dQkZ+Rv=jAT3aoKw@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> [ Just a re-send without html crud that makes all the lists unhappy.
> I'm still on the road, the flight I was supposed to be on yesterday
> got cancelled.. ]
>
> I do note that the futex hashing seems to be broken by that commit. Or
> at least it's questionable.  It keeps hashing on "both.word",  and
> doesn't use the u64 field at all for hashing.
>
> Maybe I'm mis-reading it - I didn't apply the patch, I just looked at
> the patch and my source base separately.
>
> But the 98% regression sure says something went wrong ;)

Right you are. The pointer needs to be the starting point as it moved
ahead of word, which means it starts at word and hashes word and
offset and an extra u32 beyond the end of the key.

Thanks,

        tglx
----
diff --git a/kernel/futex.c b/kernel/futex.c
index e14f7cd45dbd..9f3251349f65 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -385,8 +385,8 @@ static inline int hb_waiters_pending(struct futex_hash_bucket *hb)
  */
 static struct futex_hash_bucket *hash_futex(union futex_key *key)
 {
-	u32 hash = jhash2((u32*)&key->both.word,
-			  (sizeof(key->both.word)+sizeof(key->both.ptr))/4,
+	u32 hash = jhash2((u32*)&key->both.ptr,
+			  (sizeof(key->both.ptr) + sizeof(key->both.word)) / 4,
 			  key->both.offset);
 	return &futex_queues[hash & (futex_hashsize - 1)];
 }

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 14:02 kernel test robot
     [not found] ` <CAHk-=wgJV7xrxsTkOG203huPShzZBEC6N_BG0KGwHBmEq4yqWg@mail.gmail.com>
2020-03-08 15:28   ` Linus Torvalds
2020-03-08 18:07     ` Thomas Gleixner [this message]
2020-03-09  8:26       ` kernel test robot
2020-03-09  8:51       ` Peter Zijlstra
2020-03-09  9:34         ` Thomas Gleixner
2020-03-09 21:42       ` [tip: locking/urgent] futex: Unbreak futex hashing tip-bot2 for Thomas Gleixner
2020-03-11  8:20       ` [futex] 8019ad13ef: will-it-scale.per_process_ops -97.8% regression Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7yy90ve.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rong.a.chen@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git