From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B19CA9EC4 for ; Wed, 30 Oct 2019 09:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25A28217D9 for ; Wed, 30 Oct 2019 09:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572426177; bh=raH+iI0aQiORbOrO2yDf8CX82VI9Uy4H5AJIucXb10M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=ChZhzVZYgV+L4j1nRucghbNUwsHrCMNbUFzdfffi+LfxP0fYAR0zEBiymk9htoYKm 6U474UHed34oQ9v+O8VDk3VL95EsJqfERhXoQlOxQac++ouQUEea6HuI1sTjLL4kto uqRG+l3tX9ra6ERjemsv6n1UogiSjTziWdWaWfv8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbfJ3JC4 (ORCPT ); Wed, 30 Oct 2019 05:02:56 -0400 Received: from mga17.intel.com ([192.55.52.151]:7949 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfJ3JC4 (ORCPT ); Wed, 30 Oct 2019 05:02:56 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 02:02:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="225264093" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2019 02:02:51 -0700 From: Felipe Balbi To: John Stultz Cc: lkml , Greg Kroah-Hartman , Rob Herring , Mark Rutland , ShuFan Lee , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Yu Chen , Hans de Goede , Andy Shevchenko , Jun Li , Valentin Schneider , Jack Pham , Linux USB List , "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v4 5/9] usb: dwc3: Rework clock initialization to be more flexible In-Reply-To: References: <20191028215919.83697-1-john.stultz@linaro.org> <20191028215919.83697-6-john.stultz@linaro.org> <87k18nj4mj.fsf@gmail.com> Date: Wed, 30 Oct 2019 11:02:51 +0200 Message-ID: <87h83qhah0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, John Stultz writes: > On Tue, Oct 29, 2019 at 2:14 AM Felipe Balbi wrote: >> John Stultz writes: >> >> > The dwc3 core binding specifies three clocks: >> > ref, bus_early, and suspend >> > >> > which are all controlled in the driver together. >> > >> > However some variants of the hardware my not have all three clks >> ^^ >> may >> >> In fact *all* platforms have all three clocks. It's just that in some >> cases clock pins are shorted together (or take input from same clock). >> > ... >> another option would be to pass three clocks with the same phandle. That >> would even make sure that clock usage counts are correct, no? > > Hey Felipe! > > So I actually had done that initially (and it seemed to work), but Rob > suggested this way instead. > I'm fine with either, as long as having multiple references to the > same clk in the enable/disable paths doesn't cause trouble. > > Thanks so much for the review here! same as the other patch, if we're supposed to describe the HW, then we should describe what's actually happening. -- balbi