From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52871CA9EC0 for ; Mon, 28 Oct 2019 21:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22E6A218AC for ; Mon, 28 Oct 2019 21:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732765AbfJ1Vus (ORCPT ); Mon, 28 Oct 2019 17:50:48 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:55922 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729738AbfJ1Vur (ORCPT ); Mon, 28 Oct 2019 17:50:47 -0400 Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K9qk2100a5TFNlm039qlNT; Mon, 28 Oct 2019 22:50:45 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 22:50:45 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Mark Brown , alsa-devel@alsa-project.org Subject: Re: [PATCH 32/46] ASoC: pxa: i2s: use normal MMIO accessors References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-32-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 22:50:44 +0100 In-Reply-To: <20191018154201.1276638-32-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:47 +0200") Message-ID: <87h83sk097.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > To avoid dereferencing hardwired constant pointers from a global header > file, change the driver to use devm_platform_ioremap_resource for getting > an __iomem pointer, and then using readl/writel on that. > > Each pointer dereference gets changed by a search&replace, which leads > to a few overlong lines, but seems less risky than trying to clean up > the code at the same time. > > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert