From: ebiederm@xmission.com (Eric W. Biederman)
To: zzoru <zzoru007@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
"davem\@davemloft.net" <davem@davemloft.net>,
Andrey Vagin <avagin@virtuozzo.com>,
"dsahern\@gmail.com" <dsahern@gmail.com>,
"nicolas.dichtel\@6wind.com" <nicolas.dichtel@6wind.com>,
"tyhicks\@canonical.com" <tyhicks@canonical.com>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"syzkaller\@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: net/core: BUG in copy_net_ns()
Date: Mon, 14 Jan 2019 12:29:38 -0600 [thread overview]
Message-ID: <87h8eb854d.fsf@xmission.com> (raw)
In-Reply-To: <CALRZ7UvMbrwLb7UVgcVa9+z5yqVfJ6taj2tzpsFhWU1Cdw2J1A@mail.gmail.com> (zzoru's message of "Mon, 14 Jan 2019 21:06:27 +0900")
zzoru <zzoru007@gmail.com> writes:
> I think that it is exactly same to:
> https://groups.google.com/forum/#!searchin/linux.kernel/cleanup_net$20is$20slow%7Csort:date/linux.kernel/IMJ9OzonDSI/QH86oy1PAQAJ
> Already, patch was maded, but maybe he forgot to push it.
That patch was made to address speed, and lifetime of network stack
objects. At best it will make things go faster (a good thing), and
reduce the memory consumption during a test (another good thing).
The patch you point to will not correct your memory corruption.
So right now the best hypothesis seems to be Dmitriy's idea that
there is stack overflow causing corruption. You have a lot of stack
debugging already enabled but I don't see CONFIG_VMAP_STACK enabled
which might catch something ordinary stack overflow checking won't.
Any chance you can enable CONFIG_VMAP_STACK and see if it is stack
overflow?
With a little luck you will catch the stack overflow in the act and we
can see the problematic code path.
Eric
next prev parent reply other threads:[~2019-01-14 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 18:07 net/core: BUG in copy_net_ns() zzoru
2019-01-11 20:33 ` Eric W. Biederman
2019-01-11 20:41 ` Kirill Tkhai
2019-01-11 23:31 ` zzoru
2019-01-11 23:50 ` Eric W. Biederman
[not found] ` <CALRZ7Utk6NCGRN6mZQnF1v1a=cTWt1-JzRjLdiD14FTQC=fysg@mail.gmail.com>
2019-01-14 11:58 ` Dmitry Vyukov
2019-01-14 18:12 ` Eric W. Biederman
[not found] ` <CALRZ7UvMbrwLb7UVgcVa9+z5yqVfJ6taj2tzpsFhWU1Cdw2J1A@mail.gmail.com>
2019-01-14 18:29 ` Eric W. Biederman [this message]
2019-01-15 10:36 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8eb854d.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=avagin@virtuozzo.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dvyukov@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=syzkaller@googlegroups.com \
--cc=tyhicks@canonical.com \
--cc=zzoru007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).