From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: marvell: armada-ap806: reserve PSCI area
Date: Wed, 26 Dec 2018 17:16:37 +0100 [thread overview]
Message-ID: <87h8f09sbe.fsf@bootlin.com> (raw)
In-Reply-To: <20181221164503.5128-1-xypron.glpk@gmx.de> (Heinrich Schuchardt's message of "Fri, 21 Dec 2018 17:45:03 +0100")
Hi Heinrich,
On ven., déc. 21 2018, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> The memory area [0x4000000-0x4200000[ is occupied by the PSCI firmware. Any
> attempt to access it from Linux leads to an immediate crash.
>
> So let's make the same memory reservation as the vendor kernel.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
We got a similar patch one month ago and Russell King pointed that it
didn't match waht he saw on his MACCHIATObin:
http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/612360.html
on mine under U-Boot I got:
Marvell>> md 0x4000000
04000000: 00000000 00000007 00000005 00000040 ............@...
04000010: 00000001 00001000 00000007 00000001 ................
04000020: 00000008 00000000 00000009 00000000 ................
04000030: 0000000a 00000000 ffffffff ffffffff ................
04000040: ffffffff ffffffff ffffffff ffffffff ................
04000050: ffffffff ffffffff ffffffff ffffffff ................
04000060: ffffffff ffffffff ffffffff ffffffff ................
04000070: ffffffff ffffffff ffffffff ffffffff ................
04000080: ffffffff ffffffff ffffffff ffffffff ................
04000090: ffffffff ffffffff ffffffff ffffffff ................
040000a0: ffffffff ffffffff ffffffff ffffffff ................
040000b0: ffffffff ffffffff ffffffff ffffffff ................
040000c0: ffffffff ffffffff ffffffff ffffffff ................
040000d0: ffffffff ffffffff ffffffff ffffffff ................
040000e0: ffffffff ffffffff ffffffff ffffffff ................
040000f0: ffffffff ffffffff ffffffff ffffffff ................
In my case I have an old ATF, however this kind of setting should be
done by the bootloader.
I am interested by your claim about causing an immediate crash when
accessing this region. How did you trigger it?
Gregory
> ---
> v2
> Move the change from armada-8040-mcbin.dts to armada-ap806.dtsi.
> I only have a MACCHIATObin for testing but
> https://github.com/MarvellEmbeddedProcessors/linux-marvell
> has the reservation in that file.
> ---
> arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> index 7d94c1fa592a..f8dafef83db0 100644
> --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi
> @@ -28,6 +28,17 @@
> method = "smc";
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + psci-area@4000000 {
> + reg = <0x0 0x4000000 0x0 0x200000>;
> + no-map;
> + };
> + };
> +
> ap806 {
> #address-cells = <2>;
> #size-cells = <2>;
> --
> 2.19.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-12-26 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 16:45 [PATCH v2 1/1] arm64: dts: marvell: armada-ap806: reserve PSCI area Heinrich Schuchardt
2018-12-26 16:16 ` Gregory CLEMENT [this message]
2018-12-26 17:09 ` Heinrich Schuchardt
2019-01-10 6:34 ` Emmanuel Vadot
2019-01-10 11:01 ` Gregory CLEMENT
2019-01-10 11:04 ` Gregory CLEMENT
2019-01-20 14:14 ` Heinrich Schuchardt
2019-01-21 10:41 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8f09sbe.fsf@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).