linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mihir Mehta <mihir@cs.utexas.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Expand a slightly out-of-date comment
Date: Sat, 29 Sep 2018 19:04:41 +0900	[thread overview]
Message-ID: <87h8i8ei12.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20180928194947.23932-1-mihir@cs.utexas.edu> (Mihir Mehta's message of "Fri, 28 Sep 2018 14:49:47 -0500")

Mihir Mehta <mihir@cs.utexas.edu> writes:

> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
> ---
>  fs/fat/dir.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 7f5f369..f4db13f 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -369,7 +369,9 @@ static int fat_parse_short(struct super_block *sb,
>  	}
>  
>  	memcpy(work, de->name, sizeof(work));
> -	/* see namei.c, msdos_format_name */
> +	/* For an explanation of the special treatment of 0x05 in
> +	 * filenames, see msdos_format_name in namei_msdos.c 
> +	 */
>  	if (work[0] == 0x05)
>  		work[0] = 0xE5;

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2018-09-29 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27 15:00 [PATCH] fat: Expand a slightly out-of-date comment Mihir Mehta
2018-09-28 10:32 ` OGAWA Hirofumi
2018-09-28 19:49   ` Mihir Mehta
2018-09-29 10:04     ` OGAWA Hirofumi [this message]
2018-10-02 22:32     ` Andrew Morton
2018-10-02 23:48       ` Mihir Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8i8ei12.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihir@cs.utexas.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).