From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbeEKNrS (ORCPT ); Fri, 11 May 2018 09:47:18 -0400 Received: from ozlabs.org ([203.11.71.1]:42589 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753042AbeEKNrR (ORCPT ); Fri, 11 May 2018 09:47:17 -0400 Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Kees Cook Cc: Andrew Morton , LKML , Matthew Wilcox , Yury Norov , Andy Shevchenko , Geert Uytterhoeven , Linus Torvalds Subject: Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly In-Reply-To: References: <20180509114328.9887-1-mpe@ellerman.id.au> Date: Fri, 11 May 2018 23:47:15 +1000 Message-ID: <87h8neqp7g.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > On Wed, May 9, 2018 at 4:43 AM, Michael Ellerman wrote: >> From: Matthew Wilcox >> >> I had neglected to increment the error counter when the tests failed, >> which made the tests noisy when they fail, but not actually return an >> error code. >> >> Reported-by: Michael Ellerman >> Signed-off-by: Matthew Wilcox >> Fixes: 3cc78125a081 ("lib/test_bitmap.c: add optimisation tests") >> Cc: stable@vger.kernel.org # v4.13+ >> Tested-by: Michael Ellerman > > FWIW: > > Reviewed-by: Kees Cook Thanks. cheers