linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Minchan Kim <minchan@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jerome Marchand <jmarchan@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: [zram] ltp inspired explosion  - master v4.13-rc1-3-g87b2c3fc6317
Date: Tue, 08 Aug 2017 19:30:34 +1000	[thread overview]
Message-ID: <87h8xio18l.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170802234741.GE32020@bbox>

Minchan Kim <minchan@kernel.org> writes:
> On Wed, Aug 02, 2017 at 02:24:20PM +1000, Michael Ellerman wrote:
>> Minchan Kim <minchan@kernel.org> writes:
>> > From 0ffbd3c8769fdf56e2f14908f890f9d1703ed32e Mon Sep 17 00:00:00 2001
>> > From: Minchan Kim <minchan@kernel.org>
>> > Date: Tue, 25 Jul 2017 15:15:18 +0900
>> > Subject: [PATCH] zram: do not free pool->size_class
>> >
>> > Mike reported kernel goes oops with ltp:zram03 testcase.
>> ...
>> >
>> > He bisected the problem is [1].
>> >
>> > By [1], zram doesn't use double pointer for pool->size_class any more
>> > in zs_create_pool so counter function zs_destroy_pool don't need to
>> > free it, either. Otherwise, it does kfree wrong address and then,
>> > kernel goes Oops.
>> >
>> > [1] cf8e0fedf078 mm/zsmalloc: simplify zs_max_alloc_size handling
>> >
>> > Cc: Jerome Marchand <jmarchan@redhat.com>
>> > Reported-by: Mike Galbraith <efault@gmx.de>
>> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>> > ---
>> >  mm/zsmalloc.c | 1 -
>> >  1 file changed, 1 deletion(-)
>> 
>> I just bisected this too.
>
> Sorry for bothering you.

No worries, bugs happen.

>> How about a fixes tag to help the next chump who hits it?
>> 
>> Fixes: cf8e0fedf078 ("mm/zsmalloc: simplify zs_max_alloc_size handling")
>
> Thanks for good suggestion.
> Andrew already did it and just sent to Linus.

Great, thanks all.

cheers

      reply	other threads:[~2017-08-08  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  9:17 [zram] ltp inspired explosion - master v4.13-rc1-3-g87b2c3fc6317 Mike Galbraith
2017-07-24 18:17 ` Mike Galbraith
2017-07-25  6:26   ` Minchan Kim
2017-07-25  8:30     ` Mike Galbraith
2017-08-02  4:24     ` Michael Ellerman
2017-08-02 23:47       ` Minchan Kim
2017-08-08  9:30         ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8xio18l.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).