From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316AbdDPCrS (ORCPT ); Sat, 15 Apr 2017 22:47:18 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34880 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754504AbdDPCrP (ORCPT ); Sat, 15 Apr 2017 22:47:15 -0400 From: Nicolai Stange To: Daniel Lezcano Cc: Nicolai Stange , Michal Simek , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks References: <20170326134403.16226-1-nicstange@gmail.com> <20170330194528.7047-1-nicstange@gmail.com> <20170407131429.GD2078@mai> Date: Sun, 16 Apr 2017 04:47:11 +0200 In-Reply-To: <20170407131429.GD2078@mai> (Daniel Lezcano's message of "Fri, 7 Apr 2017 15:14:29 +0200") Message-ID: <87h91pkr0w.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Daniel, On Fri, Apr 07 2017, Daniel Lezcano wrote: > On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote: >> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c >> index 999066192715..545ccd46edb3 100644 >> --- a/arch/microblaze/kernel/timer.c >> +++ b/arch/microblaze/kernel/timer.c >> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void) >> clockevent_xilinx_timer.shift); >> clockevent_xilinx_timer.max_delta_ns = >> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer); >> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0; > > Can you take the opportunity to fix the type (unsigned long) ? Hmm, I personally think that it'd be better to leave the u32 there as it corresponds to the hardware's counter width? clockevent_delta2ns()' latch argument has been of type unsigned long from the beginning and this might indicate that at least this driver's original author followed this line of reasoning... OTOH, I think that u32 is equivalent to unsigned long on microblaze, so it doesn't matter much. Does the above convince you or do you still want the - clockevent_xilinx_timer.max_delta_ticks = (u32)~0; + clockevent_xilinx_timer.max_delta_ticks = ~0UL; change? Thanks, Nicolai