From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdBFLZf convert rfc822-to-8bit (ORCPT ); Mon, 6 Feb 2017 06:25:35 -0500 Received: from mga14.intel.com ([192.55.52.115]:53217 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdBFLZe (ORCPT ); Mon, 6 Feb 2017 06:25:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,342,1477983600"; d="scan'208";a="817564680" From: Jani Nikula To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support In-Reply-To: <20170131160319.9695-4-noralf@tronnes.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170131160319.9695-1-noralf@tronnes.org> <20170131160319.9695-4-noralf@tronnes.org> Date: Mon, 06 Feb 2017 13:25:17 +0200 Message-ID: <87h947blya.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Jan 2017, Noralf Trønnes wrote: > +static bool mipi_dbi_command_is_read(struct mipi_dbi *mipi, u8 cmd) Okay this is one giant bikeshedding nitpick, but here goes anyway. Why do you call MIPI DBI just "mipi", here and all around? Why not "mipi_dbi" or "dbi"? We never talk about "vesa" displays or use that as a shorthand when we refer to Display Port either. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center