From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933250AbcISG37 (ORCPT ); Mon, 19 Sep 2016 02:29:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46204 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759050AbcISG3v (ORCPT ); Mon, 19 Sep 2016 02:29:51 -0400 X-IMSS-HAND-OFF-DIRECTIVE: 127.0.0.1:10026 From: "Aneesh Kumar K.V" To: Reza Arbab , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Jonathan Corbet , Andrew Morton Cc: Bharata B Rao , Nathan Fontenot , Stewart Smith , Alistair Popple , Balbir Singh , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] mm: enable CONFIG_MOVABLE_NODE on powerpc In-Reply-To: <1473883618-14998-4-git-send-email-arbab@linux.vnet.ibm.com> References: <1473883618-14998-1-git-send-email-arbab@linux.vnet.ibm.com> <1473883618-14998-4-git-send-email-arbab@linux.vnet.ibm.com> Date: Mon, 19 Sep 2016 11:59:35 +0530 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16091906-8235-0000-0000-0000093B66D8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005783; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000185; SDB=6.00759053; UDB=6.00360662; IPR=6.00533208; BA=6.00004734; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012708; XFM=3.00000011; UTC=2016-09-19 06:29:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16091906-8236-0000-0000-000034F56822 Message-Id: <87h99cxv00.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-19_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609190094 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reza Arbab writes: > Onlining memory into ZONE_MOVABLE requires CONFIG_MOVABLE_NODE. Enable > the use of this config option on PPC64 platforms. > > Signed-off-by: Reza Arbab > --- > Documentation/kernel-parameters.txt | 2 +- > mm/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index a4f4d69..3d8460d 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -2344,7 +2344,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > that the amount of memory usable for all allocations > is not too small. > > - movable_node [KNL,X86] Boot-time switch to enable the effects > + movable_node [KNL,X86,PPC] Boot-time switch to enable the effects > of CONFIG_MOVABLE_NODE=y. See mm/Kconfig for details. > Movable node also does. memblock_set_bottom_up(true); What is the impact of that. Do we need changes equivalent to that ? Also where are we marking the nodes which can be hotplugged, ie where do we do memblock_mark_hotplug() ? > MTD_Partition= [MTD] > diff --git a/mm/Kconfig b/mm/Kconfig > index be0ee11..4b19cd3 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -153,7 +153,7 @@ config MOVABLE_NODE > bool "Enable to assign a node which has only movable memory" > depends on HAVE_MEMBLOCK > depends on NO_BOOTMEM > - depends on X86_64 > + depends on X86_64 || PPC64 > depends on NUMA > default n > help -aneesh