From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964931AbcIGNvb (ORCPT ); Wed, 7 Sep 2016 09:51:31 -0400 Received: from canardo.mork.no ([148.122.252.1]:42994 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933756AbcIGNv3 (ORCPT ); Wed, 7 Sep 2016 09:51:29 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Hayes Wang Cc: , , , , Oliver Neukum Subject: Re: [PATCH net-next 0/3] r8152: configuration setting Organization: m References: <1394712342-15778-215-Taiwan-albertk@realtek.com> Date: Wed, 07 Sep 2016 15:51:09 +0200 In-Reply-To: <1394712342-15778-215-Taiwan-albertk@realtek.com> (Hayes Wang's message of "Wed, 7 Sep 2016 16:12:19 +0800") Message-ID: <87h99rizsi.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u87DpaUd016400 [ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should have the final word on this ] Hayes Wang writes: > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose the USB > configuration value which they want. The default is to support vendor mode > only. > > Hayes Wang (3): > r8152: check hw version first > r8152: support ECM mode > r8152: add CONFIG_RTL8152_CONFIG_VALUE > > drivers/net/usb/Kconfig | 13 ++ > drivers/net/usb/r8152.c | 383 +++++++++++++++++++++++++++++++++++++++++------- > 2 files changed, 345 insertions(+), 51 deletions(-) So this adds a lot of code to work around the issues you introduced by unnecessarily blacklisting the CDC ECM configuration earlier, and still makes the r8152 driver handle the device even in ECM mode. Sorry, but this is a total mess. Just remove the completely unnecessary blacklist, and let the cdc_ether driver handle the device if the user selects the ECM configuration. That't how the USB system works. There is no need for any code in r8152 to do that. Ref https://lkml.org/lkml/2014/1/3/57 Bjørn