From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932390AbcCNTSn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Mar 2016 15:18:43 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:37088 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932309AbcCNTSk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Mar 2016 15:18:40 -0400
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Oded Gabbay <oded.gabbay@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
	<dri-devel@lists.freedesktop.org>,
        "Linux-Kernel\@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>
Subject: Re: [RFC 1/7] drm/amdkfd: avoid fragile and inefficient snprintf use
Organization: D03
References: <CAGXu5jJ-NApCpANjfz+bAEfwZJ8xizkM-jDHVhOPCzhxV-aqdA@mail.gmail.com>
	<1457469654-17059-1-git-send-email-linux@rasmusvillemoes.dk>
	<1457469654-17059-2-git-send-email-linux@rasmusvillemoes.dk>
	<CAFCwf113og9fFJohxu6CHYShitS27Yzviz_VsP+pUuovudGeYQ@mail.gmail.com>
X-Hashcash: 1:20:160314:oded.gabbay@gmail.com::+xVqkvkFX64gY3kx:00000000000000000000000000000000000000000Tm7
X-Hashcash: 1:20:160314:airlied@linux.ie::lWyItPE1kuPd1s6t:01Lvw
X-Hashcash: 1:20:160314:keescook@chromium.org::1y5kCLgYqXOstQmu:00000000000000000000000000000000000000001Ubt
X-Hashcash: 1:20:160314:akpm@linux-foundation.org::TSlDzolEKeqZcwe3:0000000000000000000000000000000000002I9L
X-Hashcash: 1:20:160314:linux-kernel@vger.kernel.org::ITQmYR3ILoxUgjAE:0000000000000000000000000000000004Tun
X-Hashcash: 1:20:160314:dri-devel@lists.freedesktop.org::alaujVKbFo6W8sZH:000000000000000000000000000000Bzmo
Date: Mon, 14 Mar 2016 20:18:36 +0100
In-Reply-To: <CAFCwf113og9fFJohxu6CHYShitS27Yzviz_VsP+pUuovudGeYQ@mail.gmail.com>
	(Oded Gabbay's message of "Mon, 14 Mar 2016 16:33:18 +0200")
Message-ID: <87h9g8eulv.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 14 2016, Oded Gabbay <oded.gabbay@gmail.com> wrote:

> On Tue, Mar 8, 2016 at 10:40 PM, Rasmus Villemoes
> <linux@rasmusvillemoes.dk> wrote:
>> Passing overlapping source and destination buffers to snprintf
>> formally has undefined behaviour and is rather fragile. While the
>
> I saw there were some different opinions on this.
> Have the fixes to the other drivers been taken ?
>

I rewrote this (as well as the joystick/analog.c and wlcore/boot.c
patches) to use seq_buf, and this patch in particular became much
simpler. But since akpm and Alan don't think there's anything to fix I'm
going to drop the series; if anyone wants to pursue this I'll be happy
to send them my v2.

Rasmus