From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbcBENGe (ORCPT ); Fri, 5 Feb 2016 08:06:34 -0500 Received: from mga04.intel.com ([192.55.52.120]:53553 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753559AbcBENGc (ORCPT ); Fri, 5 Feb 2016 08:06:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,400,1449561600"; d="scan'208";a="897020245" From: Alexander Shishkin To: Chunyan Zhang , mathieu.poirier@linaro.org Cc: robh@kernel.org, broonie@kernel.org, pratikp@codeaurora.org, nicolas.guion@st.com, corbet@lwn.net, mark.rutland@arm.com, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, Russell King Subject: Re: [PATCH V2 6/6] coresight-stm: adding driver for CoreSight STM component In-Reply-To: <1454487337-30184-7-git-send-email-zhang.chunyan@linaro.org> References: <1454487337-30184-1-git-send-email-zhang.chunyan@linaro.org> <1454487337-30184-7-git-send-email-zhang.chunyan@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 05 Feb 2016 15:06:20 +0200 Message-ID: <87h9hn5msz.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chunyan Zhang writes: > +#ifndef CONFIG_64BIT > +static inline void __raw_writeq(u64 val, volatile void __iomem *addr) > +{ > + asm volatile("strd %1, %0" > + : "+Qo" (*(volatile u64 __force *)addr) > + : "r" (val)); > +} Is it really ok to do this for all !64bit arms, inside a driver, just like that? I'm not an expert, but I'm pretty sure there's more to it. Regards, -- Alex