From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756794AbbLHOsI (ORCPT ); Tue, 8 Dec 2015 09:48:08 -0500 Received: from tiger.mobileactivedefense.com ([217.174.251.109]:49953 "EHLO tiger.mobileactivedefense.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbbLHOsH (ORCPT ); Tue, 8 Dec 2015 09:48:07 -0500 From: Rainer Weikusat To: David Miller Cc: rweikusat@mobileactivedefense.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix inverted test in __skb_recv_datagram In-Reply-To: <20151207.222827.1680789119862020474.davem@davemloft.net> (David Miller's message of "Mon, 07 Dec 2015 22:28:27 -0500 (EST)") References: <20151206.233038.1580536748391971635.davem@davemloft.net> <874mft7sur.fsf_-_@doppelsaurus.mobileactivedefense.com> <87vb8925vx.fsf_-_@doppelsaurus.mobileactivedefense.com> <20151207.222827.1680789119862020474.davem@davemloft.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) Date: Tue, 08 Dec 2015 14:47:56 +0000 Message-ID: <87h9jt809v.fsf@doppelsaurus.mobileactivedefense.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (tiger.mobileactivedefense.com [217.174.251.109]); Tue, 08 Dec 2015 14:48:02 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As the kernel generally uses negated error numbers, *err needs to be compared with -EAGAIN (d'oh). Signed-off-by: Rainer Weikusat Fixes: ea3793ee29d3 ("core: enable more fine-grained datagram reception control") --- diff --git a/net/core/datagram.c b/net/core/datagram.c index 7daff66..fa9dc64 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -275,7 +275,7 @@ struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned int flags, if (skb) return skb; - if (*err != EAGAIN) + if (*err != -EAGAIN) break; } while (timeo && !__skb_wait_for_more_packets(sk, err, &timeo, last));