From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758329AbbKSKOg (ORCPT ); Thu, 19 Nov 2015 05:14:36 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34363 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757512AbbKSKOd (ORCPT ); Thu, 19 Nov 2015 05:14:33 -0500 From: Rasmus Villemoes To: Andy Shevchenko Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/7] test_hexdump: test all possible group sizes for overflow Organization: D03 References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-7-git-send-email-andriy.shevchenko@linux.intel.com> X-Hashcash: 1:20:151119:andriy.shevchenko@linux.intel.com::DJugNxLI9wk1+W4b:000000000000000000000000000016Im X-Hashcash: 1:20:151119:linux-kernel@vger.kernel.org::tS6DEJP3gnHSb6Y4:0000000000000000000000000000000001UHb X-Hashcash: 1:20:151119:akpm@linux-foundation.org::jE34Rievml2Xq2wp:00000000000000000000000000000000000058oJ Date: Thu, 19 Nov 2015 11:14:31 +0100 In-Reply-To: <1447259718-19647-7-git-send-email-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Wed, 11 Nov 2015 18:35:17 +0200") Message-ID: <87h9kis3co.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11 2015, Andy Shevchenko wrote: > Currently only one combination is tested for overflow, i.e. rowsize = 16, > groupsize = 1, len = 1. Do various test to go all possible branches. > > Signed-off-by: Andy Shevchenko > --- > lib/test_hexdump.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c > index 9b95b67..fa2f4af 100644 > --- a/lib/test_hexdump.c > +++ b/lib/test_hexdump.c > @@ -126,12 +126,13 @@ static void __init test_hexdump_set(int rowsize, bool ascii) > test_hexdump(len, rowsize, 1, ascii); > } > > -static void __init test_hexdump_overflow(size_t buflen, bool ascii) > +static void __init test_hexdump_overflow(size_t buflen, size_t len, > + int rowsize, int groupsize, > + bool ascii) > { > char test[TEST_HEXDUMP_BUF_SIZE]; > char buf[TEST_HEXDUMP_BUF_SIZE]; > - size_t len = 1; > - int rs = 16, gs = 1; > + int rs = rowsize, gs = groupsize; > int ae, he, e, r; > bool a; > > @@ -170,6 +171,18 @@ static void __init test_hexdump_overflow(size_t buflen, bool ascii) > } > } > > +static void __init test_hexdump_overflow_set(size_t buflen, bool ascii) > +{ > + unsigned int i = 0; > + > + do { > + int gs = 1 << i; > + size_t len = get_random_int() % 16 + gs; > + > + test_hexdump_overflow(buflen, rounddown(len, gs), 16, gs, ascii); > + } while (i++ < 3); > +} aren't you missing a test_hexdump_overflow(buflen, rounddown(len, gs), 32, gs, ascii); here to also exercise the rowsize==32 code? > + > static int __init test_hexdump_init(void) > { > unsigned int i; > @@ -186,10 +199,10 @@ static int __init test_hexdump_init(void) > test_hexdump_set(rowsize, true); > > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) > - test_hexdump_overflow(i, false); > + test_hexdump_overflow_set(i, false); > > for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) > - test_hexdump_overflow(i, true); > + test_hexdump_overflow_set(i, true); It seems neater to do one loop: for (i = 0; i <= TEST_HEXDUMP_BUF_SIZE; i++) { test_hexdump_overflow_set(i, false); test_hexdump_overflow_set(i, true); } Rasmus