From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Namhyung Kim <namhyung.kim@lge.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf bench sched: Add --threaded 0/1 option
Date: Mon, 23 Sep 2013 15:52:33 +0900 [thread overview]
Message-ID: <87hadcqbbi.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130917114256.GA31159@gmail.com> (Ingo Molnar's message of "Tue, 17 Sep 2013 13:42:56 +0200")
Hi Ingo,
Just a few nitpicks...
On Tue, 17 Sep 2013 13:42:56 +0200, Ingo Molnar wrote:
> Allow the measurement of thread versus process context switch performance.
>
> The default stays at 'process' based measurement, like lmbench's lat_ctx
> benchmark.
>
> Sample output:
>
> comet:~/tip/tools/perf> taskset 1 ./perf bench sched pipe --threaded 0
> # Running sched/pipe benchmark...
> # Executed 1000000 pipe operations between two processes
>
> Total time: 4.138 [sec]
>
> 4.138729 usecs/op
> 241620 ops/sec
> comet:~/tip/tools/perf> taskset 1 ./perf bench sched pipe --threaded 1
Why not just make it boolean? IMHO the integer argument can confuse
users as they can think it a number of threads..
> # Running sched/pipe benchmark...
> # Executed 1000000 pipe operations between two threads
>
> Total time: 3.667 [sec]
>
> 3.667667 usecs/op
> 272652 ops/sec
>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c
> index 69cfba8..7630dc6 100644
> --- a/tools/perf/bench/sched-pipe.c
> +++ b/tools/perf/bench/sched-pipe.c
> @@ -28,12 +28,25 @@
> #include <sys/time.h>
> #include <sys/types.h>
>
> +#include <pthread.h>
> +
> +struct thread_data {
> + int nr;
> + int pipe_read;
> + int pipe_write;
> + pthread_t pthread;
> +};
> +
> #define LOOPS_DEFAULT 1000000
> static int loops = LOOPS_DEFAULT;
>
> +static int threaded = 0;
> +
> static const struct option options[] = {
> OPT_INTEGER('l', "loop", &loops,
> "Specify number of loops"),
> + OPT_INTEGER('T', "threaded", &threaded,
> + "Specify threaded/process based task setup"),
> OPT_END()
> };
>
> @@ -42,13 +55,38 @@ static const char * const bench_sched_pipe_usage[] = {
> NULL
> };
>
> +static void *worker_thread(void *__tdata)
> +{
> + struct thread_data *td = __tdata;
Whitespace damaged. Otherwise looks good to me!
Thanks,
Namhyung
> + int m = 0, i;
> + int ret;
> +
> + for (i = 0; i < loops; i++) {
> + if (!td->nr) {
> + ret = read(td->pipe_read, &m, sizeof(int));
> + BUG_ON(ret != sizeof(int));
> + ret = write(td->pipe_write, &m, sizeof(int));
> + BUG_ON(ret != sizeof(int));
> + } else {
> + ret = write(td->pipe_write, &m, sizeof(int));
> + BUG_ON(ret != sizeof(int));
> + ret = read(td->pipe_read, &m, sizeof(int));
> + BUG_ON(ret != sizeof(int));
> + }
> + }
> +
> + return NULL;
> +}
next prev parent reply other threads:[~2013-09-23 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 11:42 [PATCH] perf bench sched: Add --threaded 0/1 option Ingo Molnar
2013-09-23 6:52 ` Namhyung Kim [this message]
2013-09-23 8:17 ` [PATCH] perf bench sched: Add --threaded option Ingo Molnar
2013-10-15 5:28 ` [tip:perf/core] " tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hadcqbbi.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).