From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD8AC433EF for ; Wed, 11 May 2022 17:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345736AbiEKRl5 (ORCPT ); Wed, 11 May 2022 13:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245572AbiEKRlz (ORCPT ); Wed, 11 May 2022 13:41:55 -0400 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2087521A953; Wed, 11 May 2022 10:41:53 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:39398) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1noqLQ-00FuHr-O2; Wed, 11 May 2022 11:41:52 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:37824 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1noqLO-001d7U-Ly; Wed, 11 May 2022 11:41:52 -0600 From: "Eric W. Biederman" To: Thomas Gleixner Cc: linux-arch@vger.kernel.org, Tejun Heo , Peter Zijlstra , Vincent Guittot , Al Viro , Jens Axboe , Linus Torvalds , linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?B?0JzQsNC60YHQuNC8INCa0YPRgtGP0LLQuNC9?= References: <87mtfu4up3.fsf@email.froward.int.ebiederm.org> <20220506141512.516114-1-ebiederm@xmission.com> <87fslhpi58.ffs@tglx> <87v8udwhc6.fsf@email.froward.int.ebiederm.org> Date: Wed, 11 May 2022 12:41:44 -0500 In-Reply-To: <87v8udwhc6.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Tue, 10 May 2022 10:14:01 -0500") Message-ID: <87ilqcuftz.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1noqLO-001d7U-Ly;;;mid=<87ilqcuftz.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1/WkcezZ++DvlUbGu03UhymtxgbMnY4ZO0= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 1/7] kthread: Don't allocate kthread_struct for init and umh X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Eric W. Biederman" writes: > Thomas Gleixner writes: > >> I'm worried that there are more of these issues lurking. Haven't looked >> yet. > > I looked earlier and I missed this one. I am going to look again today, > along with applying the obvious fix to task_tick_numa. So I have just looked again and I don't see anything. There are a couple of subtle issues on x86. Especially with saving floating point but as I read the code copy_thread initializes things properly so that code that doesn't touch floating point registers doesn't need to do anything. The important thing for lurking issues is that even if I missed something practically all of the uses of PF_KTHREAD are on x86 or generic code so they should be flushed out quickly. Eric