From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752588AbeA0Jhm (ORCPT ); Sat, 27 Jan 2018 04:37:42 -0500 Received: from ozlabs.org ([103.22.144.67]:53757 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbeA0Jhk (ORCPT ); Sat, 27 Jan 2018 04:37:40 -0500 From: Michael Ellerman To: "Aneesh Kumar K.V" , Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 2/5] powerpc/32: Fix hugepage allocation on 8xx at hint address In-Reply-To: <87shb2z22l.fsf@linux.vnet.ibm.com> References: <49148d07955d3e5f963cedf9adcfcc37c3e03ef4.1516179904.git.christophe.leroy@c-s.fr> <87shb2z22l.fsf@linux.vnet.ibm.com> Date: Sat, 27 Jan 2018 20:37:35 +1100 Message-ID: <87inbn3an4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Aneesh Kumar K.V" writes: > Christophe Leroy writes: > >> On the 8xx, the page size is set in the PMD entry and applies to >> all pages of the page table pointed by the said PMD entry. >> ... >> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c >> index a9b9083c5e49..79e1378ee303 100644 >> --- a/arch/powerpc/mm/hugetlbpage.c >> +++ b/arch/powerpc/mm/hugetlbpage.c >> @@ -553,9 +553,11 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, >> struct hstate *hstate = hstate_file(file); >> int mmu_psize = shift_to_mmu_psize(huge_page_shift(hstate)); >> >> +#ifdef CONFIG_PPC_RADIX_MMU >> if (radix_enabled()) >> return radix__hugetlb_get_unmapped_area(file, addr, len, >> pgoff, flags); >> +#endif > > if (0) didn't remove the following radix__hugetlb_get_unmapped_area for > you? It will remove the call, but you still need at least a prototype, or an empty static inline. cheers