From: Eric Anholt <eric@anholt.net>
To: Gerd Hoffmann <kraxel@redhat.com>, linux-rpi-kernel@lists.infradead.org
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, swarren@wwwdotorg.org,
lee@kernel.org, linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig
Date: Fri, 03 Feb 2017 09:26:14 -0800 [thread overview]
Message-ID: <87inorp4nd.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1486123913-31705-5-git-send-email-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
Gerd Hoffmann <kraxel@redhat.com> writes:
> ---
> arch/arm/configs/bcm2835_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> index 4b89f4e..3767c24 100644
> --- a/arch/arm/configs/bcm2835_defconfig
> +++ b/arch/arm/configs/bcm2835_defconfig
> @@ -92,6 +92,7 @@ CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_PLTFM=y
> CONFIG_MMC_SDHCI_IPROC=y
> +CONFIG_MMC_BCM2835=y
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
If you end up resubmitting this, could you extend the commit message of
the defconfig changes to explain why it's being done? Something like:
"We need to enable this controller so that we can switch the SD card's
pinmux over to it by default, which will improve storage read/write
speed."
(even better if we have some sort of stats on how much better it is).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-02-03 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 12:11 [PATCH v2 0/8] mmc: bcm2835: Add new driver for the sdhost controller Gerd Hoffmann
2017-02-03 12:11 ` [PATCH v2 1/8] dt-bindings: Add binding for brcm,bcm2835-sdhost Gerd Hoffmann
2017-02-03 12:11 ` [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller Gerd Hoffmann
2017-02-06 20:34 ` Stefan Wahren
2017-02-07 8:02 ` Gerd Hoffmann
2017-02-07 8:24 ` Stefan Wahren
2017-02-08 18:08 ` Stefan Wahren
2017-02-03 12:11 ` [PATCH v2 3/8] mmc: bcm2835: add sdhost controller to devicetree Gerd Hoffmann
2017-02-03 17:31 ` Eric Anholt
2017-02-03 12:11 ` [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig Gerd Hoffmann
2017-02-03 17:26 ` Eric Anholt [this message]
2017-02-03 12:11 ` [PATCH v2 5/8] arm: set CONFIG_MMC_BCM2835=y in multi_v7_defconfig Gerd Hoffmann
2017-02-03 12:11 ` [PATCH v2 6/8] arm64: set CONFIG_MMC_BCM2835=y in defconfig Gerd Hoffmann
2017-02-03 12:11 ` [PATCH v2 7/8] ARM: dts: bcm283x: switch from &sdhci to &sdhost Gerd Hoffmann
2017-02-03 12:11 ` [PATCH v2 8/8] ARM: dts: bcm2837: add &sdhci and &sdhost Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inorp4nd.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kraxel@redhat.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).