From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-sh list <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 18/19] sh: IO-DATA HDL-U (a,k.a landisk) support
Date: Wed, 29 Jun 2016 00:06:28 +0900 [thread overview]
Message-ID: <87inwtz72j.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <CAMuHMdWUr5=GSjtWD1RTuWGPiqKUh3nmwAULUNxECP3kHtHw5g@mail.gmail.com>
On Tue, 28 Jun 2016 16:51:25 +0900,
Geert Uytterhoeven wrote:
>
> Hi Sato-san,
>
> On Tue, Jun 28, 2016 at 8:36 AM, Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > .../interrupt-controller/iodata-landisk.txt | 34 ++++++++++
> > arch/sh/boot/dts/Makefile | 2 +
> > arch/sh/boot/dts/landisk.dts | 62 ++++++++++++++++++
> > drivers/irqchip/Makefile | 2 +-
> > drivers/irqchip/irq-io-landisk.c | 73 ++++++++++++++++++++++
> > 5 files changed, 172 insertions(+), 1 deletion(-)
>
> This needs to be split in two (or three) patches:
> - irqchip driver and DT
> - arch/sh
OK.
> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > create mode 100644 arch/sh/boot/dts/landisk.dts
> > create mode 100644 drivers/irqchip/irq-io-landisk.c
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > new file mode 100644
> > index 0000000..9f87f2c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/iodata-landisk.txt
> > @@ -0,0 +1,34 @@
> > +DT bindings for the I/O DATA HDL-U interrupt controller
> > +
> > +Required properties:
> > +
> > + - compatible: has to be "iodata,landisk-intc".
> > +
> > + - reg: Base address and length of interrupt controller register.
> > +
> > + - interrupt-controller: Identifies the node as an interrupt controller.
> > +
> > + - #address-cells: has to be <0>.
>
> Why do you need #address-cells? There are no subnodes.
Ouch.
I forgot remove line.
Thanks.
> > +
> > + - #interrupt-cells: has to be <1>: an interrupt index.
> > +
> > + - interrupt-map: Interrupt mapping on parent controller.
>
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/landisk.dts
> > @@ -0,0 +1,62 @@
> > +/dts-v1/;
> > +
> > +#include "sh7751.dtsi"
> > +
> > +/ {
> > + model = "I/O DATA HDL-U";
> > + compatible = "iodata,hdl-u";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + interrupt-parent = <&shintc>;
> > + chosen {
> > + stdout-path = &sci1;
> > + bootargs = "console=ttySC1,115200";
>
> The console= parameter can be removed from bootargs.
> You can specify the console speed using
>
> stdout-path = "&sci1:115200";
>
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next prev parent reply other threads:[~2016-06-28 15:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 6:36 [PATCH v3 00/19] sh: LANDISK and R2Dplus convert to device tree Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 01/19] sh: More early unflatten " Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 02/19] sh: set preset_lpj Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 03/19] sh: Use P1SEGADDR Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 04/19] sh: command line passing chosen/bootargs in devicetree Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 05/19] sh: FDT address save before bank change Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 06/19] sh: Passing FDT address on zImage Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 07/19] sh: Disable board specific code on device tree mode Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 08/19] sh: Use GENERIC_IOMAP " Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 09/19] sh: Add board specific initialize of of-generic Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 10/19] sh: SH7750/51 CPG Driver Yoshinori Sato
2016-06-28 21:02 ` Rob Herring
2016-06-28 6:36 ` [PATCH v3 11/19] sh: Add PCI host bridge driver for SH7751 Yoshinori Sato
2016-06-28 21:05 ` Rob Herring
2016-06-28 6:36 ` [PATCH v3 13/19] sh: SH7751 core dtsi Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 14/19] sh: Move common PCI stuff to arch/sh/kernel Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 15/19] pci: pci_config_window move to linux/pci.h Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 16/19] pci: PCI_HOST_GENERIC enable for SH Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 17/19] sh: Add separate DTB build rule Yoshinori Sato
2016-06-28 6:36 ` [PATCH v3 18/19] sh: IO-DATA HDL-U (a,k.a landisk) support Yoshinori Sato
2016-06-28 7:51 ` Geert Uytterhoeven
2016-06-28 15:06 ` Yoshinori Sato [this message]
2016-06-28 8:54 ` John Paul Adrian Glaubitz
2016-06-28 6:36 ` [PATCH v3 19/19] sh: Renesas R0P751RLC0011RL (a.k.a R2Dplus) support Yoshinori Sato
2016-06-28 7:54 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inwtz72j.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).