From: Marc Zyngier <maz@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property
Date: Tue, 12 Sep 2023 13:41:50 +0100 [thread overview]
Message-ID: <87jzsv4l81.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMuHMdW_d5isU5Y2p6ne6_9j1-uqWnRY=Qw34SqR5EC0CndG+Q@mail.gmail.com>
On Fri, 08 Sep 2023 10:31:35 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Marc,
>
> On Thu, Aug 11, 2022 at 4:50 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <maz@kernel.org> wrote:
> > > On Fri, 22 Jul 2022 16:11:54 +0100,
> > > Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > >
> > > > Update description for '#interrupt-cells' property to utilize the
> > > > RZG2L_{NMI,IRQX} for the first cell defined in the
> > > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > ---
> > > > v3:
> > > > * New patch
> >
> > > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml
> > > > @@ -31,8 +31,9 @@ properties:
> > > > - const: renesas,rzg2l-irqc
> > > >
> > > > '#interrupt-cells':
> > > > - description: The first cell should contain external interrupt number (IRQ0-7) and the
> > > > - second cell is used to specify the flag.
> > > > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the
> > > > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second
> > > > + cell is used to specify the flag.
> > >
> > > I think a binding should be self describing, and not rely on an opaque
> > > macro. Mentioning that there is a macro that encodes it is fine, but
> > > the values are what matter, specially when considering that other OSs
> > > could (and should be able to) write their own DTs from scratch without
> > > depending on something that is very much Linux-specific.
> >
> > The macros are not Linux-specific, and are part of the bindings.
> > But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h>
> > is the DT source file describing the board.
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Looks like this fell through the cracks?
> The two other patches from this series were applied in v6.1.
>
> Note that the current DT bindings are incorrect, as they do not take into
> account that the value of zero is used to represent the NMI.
>
> Fixes: 96fed779d3d4cb3c ("dt-bindings: interrupt-controller: Add
> Renesas RZ/G2L Interrupt Controller")
>
> Should we resend instead?
It applied cleanly to v6.6-rc1, so there should be no need.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-09-12 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 15:11 [PATCH v3 0/3] Add PHY interrupt support for ETH{0,1} on RZ/G2L and RZ/V2L SMARC EVK Lad Prabhakar
2022-07-22 15:11 ` [PATCH v3 1/3] dt-bindings: interrupt-controller: Add macros for NMI and IRQ0-7 interrupts present on RZ/G2L SoC Lad Prabhakar
2022-07-25 23:06 ` Rob Herring
2022-08-11 14:48 ` Geert Uytterhoeven
2022-07-22 15:11 ` [PATCH v3 2/3] dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property Lad Prabhakar
2022-07-24 11:01 ` Marc Zyngier
2022-08-11 14:50 ` Geert Uytterhoeven
2023-09-08 9:31 ` Geert Uytterhoeven
2023-09-12 12:41 ` Marc Zyngier [this message]
2023-09-12 12:49 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Lad Prabhakar
2022-07-22 15:11 ` [PATCH v3 3/3] arm64: dts: renesas: rzg2l-smarc-som: Add PHY interrupt support for ETH{0/1} Lad Prabhakar
2022-08-11 14:47 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzsv4l81.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).