From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A6DCC25B06 for ; Fri, 5 Aug 2022 13:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240674AbiHENHi (ORCPT ); Fri, 5 Aug 2022 09:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240864AbiHENHg (ORCPT ); Fri, 5 Aug 2022 09:07:36 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F341ADA2; Fri, 5 Aug 2022 06:07:32 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 05E773445C; Fri, 5 Aug 2022 13:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1659704851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ZJtXObBVxiCT2sToLYj1tKthIk9MsTpx8FhQ9IVmR4=; b=L08puQC5utIC+eioBJj3hsTl02pG19UCPn3+ZT6RvgnWz//QD89n0BnAexNrb4e+46AGFO OXyQ1bLa6Il6HIl96uedJDWYo+ZLxhiQVqEKCePl8pkXUAyKzCelBqaXrRZ2krokk1ZWYX K3gjVYR72ZkFAGqghrDzYzDHfkis8+4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1659704851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ZJtXObBVxiCT2sToLYj1tKthIk9MsTpx8FhQ9IVmR4=; b=idanaJzniKM0mV/0V1PptuR/uygn/fb/F7D9kFp5J+Flntf6SKJd9lmcG+bjboAOfSjlJ1 w5J5cimO3XTjSvAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BA71213A9C; Fri, 5 Aug 2022 13:07:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HSEhLBIW7WJMKQAAMHmgww (envelope-from ); Fri, 05 Aug 2022 13:07:30 +0000 Date: Fri, 05 Aug 2022 15:07:30 +0200 Message-ID: <87k07m260d.wl-tiwai@suse.de> From: Takashi Iwai To: Colin Ian King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ice1712: remove redundant assignment to new In-Reply-To: <20220805120439.2341600-1-colin.i.king@gmail.com> References: <20220805120439.2341600-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Aug 2022 14:04:39 +0200, Colin Ian King wrote: > > The variable new is initialized with a value but it is never read. It is > being re-assigned a new value in every case path in the following switch > statement. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored > to 'new' is used in the enclosing expression, the value is never actually > read from 'new' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Thanks, applied. Takashi