From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F88C43334 for ; Sun, 17 Jul 2022 09:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232768AbiGQJ6C (ORCPT ); Sun, 17 Jul 2022 05:58:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiGQJ6A (ORCPT ); Sun, 17 Jul 2022 05:58:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E2DB186C5 for ; Sun, 17 Jul 2022 02:57:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28563B80D9E for ; Sun, 17 Jul 2022 09:57:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1C58C3411E; Sun, 17 Jul 2022 09:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658051876; bh=SwRUGIYuiONdg7eAHKWwZ3Mujc4biRRS1Cegr1HAD98=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RB73boqw53PFFwQhWEcm4uDZQZRLDDG99oqBfxUrQiahGaDWsNCyEj0uzBwbpEHy3 S8dG0Wk6wrPZXRULMG20yZ+VezW9wpX0G7nEc3trGkJxJfgUCHd1VaN9hRyUtHvcz7 sfcV9jJ6l7y1aT4/8UwjwF6yYT/AiA8vY2Ha7VwyfPMZi5sBgPv3cUPHU3m1Is27ii M3M93p1WFZmvHxF5kzZ81Llz2E6mkFC9EvYM36jSfirEqQAfREYrfIlmKbjwH41Aqr xqjBsc/AUYQbZxmX1MA1lTnnWIzn+FOHO/dm2un81WgGo1rilxjocTeI6V06VqEslU yNqoL9KNtKQFg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oD12A-007zXP-4y; Sun, 17 Jul 2022 10:57:54 +0100 Date: Sun, 17 Jul 2022 10:57:47 +0100 Message-ID: <87k08c3vtw.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh Cc: mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, will@kernel.org, qperret@google.com, tabba@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, russell.king@oracle.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, drjones@redhat.com, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com Subject: Re: [PATCH v4 06/18] arm64: stacktrace: Add description of stacktrace/common.h In-Reply-To: <20220715061027.1612149-7-kaleshsingh@google.com> References: <20220715061027.1612149-1-kaleshsingh@google.com> <20220715061027.1612149-7-kaleshsingh@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, will@kernel.org, qperret@google.com, tabba@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, andreyknvl@gmail.com, russell.king@oracle.com, vincenzo.frascino@arm.com, mhiramat@kernel.org, ast@kernel.org, drjones@redhat.com, wangkefeng.wang@huawei.com, elver@google.com, keirf@google.com, yuzenghui@huawei.com, ardb@kernel.org, oupton@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, android-mm@google.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2022 07:10:15 +0100, Kalesh Singh wrote: > > Add brief description on how to use stacktrace/common.h to implement > a stack unwinder. > > Signed-off-by: Kalesh Singh > --- > arch/arm64/include/asm/stacktrace/common.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/include/asm/stacktrace/common.h b/arch/arm64/include/asm/stacktrace/common.h > index f86efe71479d..b362086f4c70 100644 > --- a/arch/arm64/include/asm/stacktrace/common.h > +++ b/arch/arm64/include/asm/stacktrace/common.h > @@ -2,6 +2,14 @@ > /* > * Common arm64 stack unwinder code. > * > + * To implement a new arm64 stack unwinder: > + * 1) Include this header > + * > + * 2) Provide implementations for the following functions: > + * - on_overflow_stack() > + * - on_accessible_stack() > + * - unwind_next() A short description of what these helpers are supposed to do would also be helpful. Thanks, M. -- Without deviation from the norm, progress is not possible.