From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC625C433FE for ; Thu, 9 Dec 2021 17:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242006AbhLIR5Q (ORCPT ); Thu, 9 Dec 2021 12:57:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231889AbhLIR5P (ORCPT ); Thu, 9 Dec 2021 12:57:15 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC83DC061746; Thu, 9 Dec 2021 09:53:41 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1639072418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/BG5QfqwWEb1VV/DgxhiFZ4nhZE79+Y1nkN0PAhNpQ=; b=kjE+xJbt1HY/8HBJlMzR3KY5f257GXq6wQiCb4ielSBtggUniQ1I3lNNdnraOwg0GEpMfu syIRikUXoAagvFD10A7VC8fdLi5KNDe8FVpgjdz238ahh5ThXTk0ftjn4sLjev21WbVmwN UdtH1rl6SMpGB3hFuvBYPFDDfZmvU6R1CRdrxcp40TncFcDN6uf+hzRVH9isczKiB43Nqg eOi5ptsv0tQWvH/JkuarfQxl1jTA329ul6SL57nsoRBvTSUj8ex83rJhKPX7X7TnTrq8uZ kYfRHVatnPWdhfVHrcCL0ZVnQkiJkHbcO3adPxb/1ct6S7VsxFetMxXinWNn4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1639072418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f/BG5QfqwWEb1VV/DgxhiFZ4nhZE79+Y1nkN0PAhNpQ=; b=W9fJDkfc99g7IIQhAnrz13+8F5imCs058D17+luFpISF83qVBUish7Usu7wFw9FwF+6ZoR uTKOefgne5k+wzAQ== To: Jason Gunthorpe Cc: LKML , Bjorn Helgaas , Marc Zygnier , Alex Williamson , Kevin Tian , Megha Dey , Ashok Raj , linux-pci@vger.kernel.org, Cedric Le Goater , xen-devel@lists.xenproject.org, Juergen Gross , Greg Kroah-Hartman , Will Deacon , Santosh Shilimkar , iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder , Laurentiu Tudor , Nishanth Menon , Tero Kristo , linux-arm-kernel@lists.infradead.org, Vinod Koul , Mark Rutland , Robin Murphy , Sinan Kaya Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data In-Reply-To: <20211208155816.GZ6385@nvidia.com> References: <20211206210307.625116253@linutronix.de> <20211206210438.688216619@linutronix.de> <20211208155816.GZ6385@nvidia.com> Date: Thu, 09 Dec 2021 18:53:37 +0100 Message-ID: <87k0gdzmu6.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 08 2021 at 11:58, Jason Gunthorpe wrote: > On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote: >> Store the properties which are interesting for various places so the MSI >> descriptor fiddling can be removed. >> >> Signed-off-by: Thomas Gleixner >> --- >> V2: Use the setter function >> --- >> drivers/pci/msi/msi.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > I took more time to look at this, to summarize my remarks on the other > patches > > I think we don't need properties. The info in the msi_desc can come > from the pci_dev which we have easy access to. This seems overall > clearer I fixed that now. > The notable one is the sysfs, but that is probably better handled by > storing a > > const char *sysfs_label > > in the dev->msi and emitting that instead of computing it. I just compute is for now via is_pci_dev() and to_pci_dev()->msi_enabled. We are still debating to remove the whole thing completely. Thanks, tglx