From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Lorenzo Colitti" <lorenzo@google.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Maciej Żenczykowski" <zenczykowski@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
mikael.beckius@windriver.com,
"Maciej Żenczykowski" <maze@google.com>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns()
Date: Mon, 26 Apr 2021 16:27:08 +0200 [thread overview]
Message-ID: <87k0opt937.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <YIa0qWdxM7vIsf/4@hirez.programming.kicks-ass.net>
On Mon, Apr 26 2021 at 14:40, Peter Zijlstra wrote:
> On Mon, Apr 26, 2021 at 02:33:00PM +0200, Thomas Gleixner wrote:
>
>> >> + force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases);
>> >> + force_local &= base->cpu_base->next_timer == timer;
>> >
>> > Using bitwise ops on a bool is cute and all, but isn't that more
>> > readable when written like:
>> >
>> > force_local = base->cpu_base == this_cpu_ptr(&hrtimer_bases) &&
>> > base->cpu_base->next_timer == timer;
>> >
>>
>> Which results in an extra conditional branch.
>
> Srlsy, compiler not smart enough?
gcc 8.3 is definitely not ...
prev parent reply other threads:[~2021-04-26 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 16:55 [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event() Maciej Żenczykowski
2021-04-13 17:14 ` Greg KH
2021-04-14 2:49 ` Lorenzo Colitti
2021-04-15 16:47 ` Thomas Gleixner
2021-04-20 3:12 ` Maciej Żenczykowski
2021-04-20 6:44 ` Thomas Gleixner
2021-04-20 8:15 ` Lorenzo Colitti
2021-04-20 14:19 ` Thomas Gleixner
2021-04-21 14:08 ` Lorenzo Colitti
2021-04-21 14:40 ` Lorenzo Colitti
2021-04-21 15:22 ` Greg KH
2021-04-22 0:08 ` Thomas Gleixner
2021-04-22 10:07 ` Thomas Gleixner
2021-04-22 14:20 ` Lorenzo Colitti
2021-04-22 15:35 ` Thomas Gleixner
2021-04-26 8:49 ` [PATCH] hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns() Thomas Gleixner
2021-04-26 9:40 ` Peter Zijlstra
2021-04-26 12:25 ` Peter Zijlstra
2021-05-14 19:29 ` Thomas Gleixner
2021-04-26 12:33 ` Thomas Gleixner
2021-04-26 12:40 ` Peter Zijlstra
2021-04-26 14:27 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0opt937.ffs@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=mikael.beckius@windriver.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).