linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mikael Beckius <mikael.beckius@windriver.com>, anna-maria@linutronix.de
Cc: linux-kernel@vger.kernel.org, mikael.beckius@windriver.com
Subject: Re: Sv: Sv: [PATCH] hrtimer: Interrupt storm on clock_settime
Date: Mon, 01 Mar 2021 10:13:17 +0100	[thread overview]
Message-ID: <87k0qrtexe.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210225111814.8383-1-mikael.beckius@windriver.com>

Micke,

On Thu, Feb 25 2021 at 12:18, Mikael Beckius wrote:

>> The proposed change breaks the reprogramming logic. To keep it working
>> cpu_base::*expires_next is only updated by hrtimer_reprogram() and
>> hrtimer_interrupt(). I will send you a patch for testing in reply to this
>> thread. The patch is compile tested only.
>> 
> Ok. I kind of guessed that would be the response as I noticed a similar comment
> during the review of the original patch which introduced the softirq_expires_next
> logic. Anyway it seemed logical to update softirq_expires_next
> when updating softirq_next_timer.

yes it seems logical to do that, but unfortunately the logic there is a
bit twisted and could do with some deobfuscation.

Thanks,

        tglx

  reply	other threads:[~2021-03-01  9:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 14:02 [PATCH] hrtimer: Interrupt storm on clock_settime Mikael Beckius
2021-02-05 15:45 ` Thomas Gleixner
2021-02-12 13:38   ` Sv: " Beckius, Mikael
2021-02-23 15:53     ` Anna-Maria Behnsen
2021-02-25 11:18       ` Sv: " Mikael Beckius
2021-03-01  9:13         ` Thomas Gleixner [this message]
2021-02-23 16:02     ` [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event() Anna-Maria Behnsen
2021-02-25 11:18       ` Sv: " Mikael Beckius
2021-03-01  9:23       ` [tip: timers/urgent] " tip-bot2 for Anna-Maria Behnsen
2021-03-06 12:00       ` tip-bot2 for Anna-Maria Behnsen
2021-03-08  8:41       ` tip-bot2 for Anna-Maria Behnsen
2021-02-09 15:22 ` [tip: timers/urgent] hrtimer: Update softirq_expires_next correctly in hrtimer_force_reprogram() tip-bot2 for Mikael Beckius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0qrtexe.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikael.beckius@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).