From: Thomas Gleixner <tglx@linutronix.de>
To: Barry Song <song.bao.hua@hisilicon.com>,
dmitry.torokhov@gmail.com, maz@kernel.org,
gregkh@linuxfoundation.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linuxarm@openeuler.org, Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH v3 01/12] genirq: add IRQF_NO_AUTOEN for request_irq
Date: Thu, 28 Jan 2021 20:54:36 +0100 [thread overview]
Message-ID: <87k0rwdegz.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20210107223926.35284-2-song.bao.hua@hisilicon.com>
Barry,
On Fri, Jan 08 2021 at 11:39, Barry Song wrote:
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index ab8567f32501..2b28314e2572 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1693,6 +1693,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
> irqd_set(&desc->irq_data, IRQD_NO_BALANCING);
> }
>
> + if (new->flags & IRQF_NO_AUTOEN)
> + irq_settings_set_noautoen(desc);
If we move this to request time flags, then setting the noautoen bit on
the irq descriptor is pretty pointless. See below.
I rather get rid of the irq_settings magic for NOAUTOEN completely.
Thanks,
tglx
---
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -61,6 +61,8 @@
* interrupt handler after suspending interrupts. For system
* wakeup devices users need to implement wakeup detection in
* their interrupt handlers.
+ * IRQF_NO_AUTOEN - Don't enable IRQ automatically when users request it. Users
+ * will enable it explicitly by enable_irq() later.
*/
#define IRQF_SHARED 0x00000080
#define IRQF_PROBE_SHARED 0x00000100
@@ -74,6 +76,7 @@
#define IRQF_NO_THREAD 0x00010000
#define IRQF_EARLY_RESUME 0x00020000
#define IRQF_COND_SUSPEND 0x00040000
+#define IRQF_NO_AUTOEN 0x00080000
#define IRQF_TIMER (__IRQF_TIMER | IRQF_NO_SUSPEND | IRQF_NO_THREAD)
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1693,7 +1693,8 @@ static int
irqd_set(&desc->irq_data, IRQD_NO_BALANCING);
}
- if (irq_settings_can_autoenable(desc)) {
+ if (!(new->flags & IRQF_NO_AUTOEN) &&
+ irq_settings_can_autoenable(desc)) {
irq_startup(desc, IRQ_RESEND, IRQ_START_COND);
} else {
/*
@@ -2086,10 +2087,15 @@ int request_threaded_irq(unsigned int ir
* which interrupt is which (messes up the interrupt freeing
* logic etc).
*
+ * Also shared interrupts do not go well with disabling auto enable.
+ * The sharing interrupt might request it while it's still disabled
+ * and then wait for interrupts forever.
+ *
* Also IRQF_COND_SUSPEND only makes sense for shared interrupts and
* it cannot be set along with IRQF_NO_SUSPEND.
*/
if (((irqflags & IRQF_SHARED) && !dev_id) ||
+ ((irqflags & IRQF_SHARED) && (irqflags & IRQF_NO_AUTOEN)) ||
(!(irqflags & IRQF_SHARED) && (irqflags & IRQF_COND_SUSPEND)) ||
((irqflags & IRQF_NO_SUSPEND) && (irqflags & IRQF_COND_SUSPEND)))
return -EINVAL;
next prev parent reply other threads:[~2021-01-28 20:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 22:39 [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 01/12] genirq: " Barry Song
2021-01-28 19:54 ` Thomas Gleixner [this message]
2021-02-01 4:08 ` Song Bao Hua (Barry Song)
2021-01-07 22:39 ` [PATCH v3 02/12] Input: ar1021 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 03/12] Input: atmel_mxt_ts " Barry Song
2021-01-07 22:39 ` [PATCH v3 04/12] Input: melfas_mip4 " Barry Song
2021-01-07 22:39 ` [PATCH v3 05/12] Input: bu21029_ts - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Barry Song
2021-01-07 22:39 ` [PATCH v3 06/12] Input: stmfts " Barry Song
2021-01-07 22:39 ` [PATCH v3 07/12] Input: zinitix " Barry Song
2021-01-07 22:39 ` [PATCH v3 08/12] Input: mms114 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-07 22:39 ` [PATCH v3 09/12] Input: wm831x-ts " Barry Song
2021-01-07 22:39 ` [PATCH v3 10/12] Input: cyttsp " Barry Song
2021-01-07 22:39 ` [PATCH v3 11/12] Input: tegra-kbc " Barry Song
2021-01-07 22:39 ` [PATCH v3 12/12] Input: tca6416-keypad " Barry Song
2021-01-21 21:38 ` [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq Song Bao Hua (Barry Song)
2021-01-27 13:49 ` gregkh
2021-01-27 19:45 ` dmitry.torokhov
2021-01-28 11:08 ` [Linuxarm] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0rwdegz.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=maz@kernel.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).