From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18EEC2BA18 for ; Sun, 5 Apr 2020 00:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFD6D20739 for ; Sun, 5 Apr 2020 00:40:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="FOJ3IBC7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbgDEAkk (ORCPT ); Sat, 4 Apr 2020 20:40:40 -0400 Received: from ozlabs.org ([203.11.71.1]:58645 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgDEAkk (ORCPT ); Sat, 4 Apr 2020 20:40:40 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48vvwG0Lq0z9sP7; Sun, 5 Apr 2020 10:40:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1586047237; bh=Ecetm/FWyw23pFJR9aYjHEPKZAqW0as9jZfLtutKHZE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FOJ3IBC7mc8ibpgD0O6posipCUoBslj9lRk5uELexERCZFzS7zW9CSUb8ptsk096b +lQHDU2ACBxl75V60QihE/lrq5o4dLFUN51Y3pcnaknvfuqfNUkhA53TyO+is2N5P/ AdZNo2eMg7ctXOPrnOsM0xsZcTRQCldx24KBrG0TodRKbhNJlrXdoyxvJh6C+fTRDm J174SpN5e7RaOOFXOIcPKC1agC94ZT8tRlERZ1/pqZ84Wj6qv+A0Y8s6y31ZVZznKP hc0MWFUe0Sg5/QOTVHcvh8FPvuV1yoeTNmD9UMUXlx0A0eurI5b0nILo816HxWGSfe I1xQhSMZyMSSg== From: Michael Ellerman To: Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Michal Suchanek Cc: Arnaldo Carvalho de Melo , Alexander Shishkin , Allison Randal , Andy Shevchenko , Arnd Bergmann , Thiago Jung Bauermann , Benjamin Herrenschmidt , Sebastian Andrzej Siewior , Claudio Carvalho , "David S. Miller" , "Eric W. Biederman" , Eric Richter , Greg Kroah-Hartman , Gustavo Luiz Duarte , Hari Bathini , Jordan Niethe , Jiri Olsa , Jonathan Cameron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Mauro Carvalho Chehab , Michael Neuling , Ingo Molnar , Namhyung Kim , Nayna Jain , Paul Mackerras , Peter Zijlstra , Rob Herring , Thomas Gleixner , Valentin Schneider , Alexander Viro Subject: Re: [PATCH v11 0/8] Disable compat cruft on ppc64le v11 In-Reply-To: <1585906885.3dbukubyr8.astroid@bobo.none> References: <20200225173541.1549955-1-npiggin@gmail.com> <1585898335.tckaz04a6x.astroid@bobo.none> <1e00a725-9710-2b80-4aff-2f284b31d2e5@c-s.fr> <1585906885.3dbukubyr8.astroid@bobo.none> Date: Sun, 05 Apr 2020 10:40:38 +1000 Message-ID: <87k12usr21.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nicholas Piggin writes: > Christophe Leroy's on April 3, 2020 5:26 pm: >> Le 03/04/2020 =C3=A0 09:25, Nicholas Piggin a =C3=A9crit=C2=A0: >>> Michal Suchanek's on March 19, 2020 10:19 pm: >>>> Less code means less bugs so add a knob to skip the compat stuff. >>>> >>>> Changes in v2: saner CONFIG_COMPAT ifdefs >>>> Changes in v3: >>>> - change llseek to 32bit instead of builing it unconditionally in fs >>>> - clanup the makefile conditionals >>>> - remove some ifdefs or convert to IS_DEFINED where possible >>>> Changes in v4: >>>> - cleanup is_32bit_task and current_is_64bit >>>> - more makefile cleanup >>>> Changes in v5: >>>> - more current_is_64bit cleanup >>>> - split off callchain.c 32bit and 64bit parts >>>> Changes in v6: >>>> - cleanup makefile after split >>>> - consolidate read_user_stack_32 >>>> - fix some checkpatch warnings >>>> Changes in v7: >>>> - add back __ARCH_WANT_SYS_LLSEEK to fix build with llseek >>>> - remove leftover hunk >>>> - add review tags >>>> Changes in v8: >>>> - consolidate valid_user_sp to fix it in the split callchain.c >>>> - fix build errors/warnings with PPC64 !COMPAT and PPC32 >>>> Changes in v9: >>>> - remove current_is_64bit() >>>> Chanegs in v10: >>>> - rebase, sent together with the syscall cleanup >>>> Changes in v11: >>>> - rebase >>>> - add MAINTAINERS pattern for ppc perf >>>=20 >>> These all look good to me. I had some minor comment about one patch but >>> not really a big deal and there were more cleanups on top of it, so I >>> don't mind if it's merged as is. >>>=20 >>> Actually I think we have a bit of stack reading fixes for 64s radix now >>> (not a bug fix as such, but we don't need the hash fault logic in radix= ), >>> so if I get around to that I can propose the changes in that series. >>>=20 >>=20 >> As far as I can see, there is a v12 > > For the most part I was looking at the patches in mpe's next-test > tree on github, if that's the v12 series, same comment applies but > it's a pretty small nitpick. Yeah I have v12 in my tree. This has floated around long enough (our fault), so I'm going to take it and we can fix anything up later. cheers