linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/vc4: Fix Kconfig indentation
@ 2019-11-21 13:29 Krzysztof Kozlowski
  2019-11-25  9:04 ` Daniel Vetter
  2019-11-27 13:13 ` Jani Nikula
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2019-11-21 13:29 UTC (permalink / raw)
  To: linux-kernel
  Cc: Krzysztof Kozlowski, Eric Anholt, David Airlie, Daniel Vetter, dri-devel

Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
	$ sed -e 's/^        /\t/' -i */Kconfig

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/gpu/drm/vc4/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
index 7c2317efd5b7..118e8a426b1a 100644
--- a/drivers/gpu/drm/vc4/Kconfig
+++ b/drivers/gpu/drm/vc4/Kconfig
@@ -22,9 +22,9 @@ config DRM_VC4
 	  our display setup.
 
 config DRM_VC4_HDMI_CEC
-       bool "Broadcom VC4 HDMI CEC Support"
-       depends on DRM_VC4
-       select CEC_CORE
-       help
+	bool "Broadcom VC4 HDMI CEC Support"
+	depends on DRM_VC4
+	select CEC_CORE
+	help
 	  Choose this option if you have a Broadcom VC4 GPU
 	  and want to use CEC.
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vc4: Fix Kconfig indentation
  2019-11-21 13:29 [PATCH] drm/vc4: Fix Kconfig indentation Krzysztof Kozlowski
@ 2019-11-25  9:04 ` Daniel Vetter
  2019-11-27 13:13 ` Jani Nikula
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2019-11-25  9:04 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux-kernel, Eric Anholt, David Airlie, Daniel Vetter, dri-devel

On Thu, Nov 21, 2019 at 09:29:19PM +0800, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> 	$ sed -e 's/^        /\t/' -i */Kconfig
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Queued in drm-misc-next for 5.6, thanks for your patch.
-Daniel

> ---
>  drivers/gpu/drm/vc4/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
> index 7c2317efd5b7..118e8a426b1a 100644
> --- a/drivers/gpu/drm/vc4/Kconfig
> +++ b/drivers/gpu/drm/vc4/Kconfig
> @@ -22,9 +22,9 @@ config DRM_VC4
>  	  our display setup.
>  
>  config DRM_VC4_HDMI_CEC
> -       bool "Broadcom VC4 HDMI CEC Support"
> -       depends on DRM_VC4
> -       select CEC_CORE
> -       help
> +	bool "Broadcom VC4 HDMI CEC Support"
> +	depends on DRM_VC4
> +	select CEC_CORE
> +	help
>  	  Choose this option if you have a Broadcom VC4 GPU
>  	  and want to use CEC.
> -- 
> 2.17.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vc4: Fix Kconfig indentation
  2019-11-21 13:29 [PATCH] drm/vc4: Fix Kconfig indentation Krzysztof Kozlowski
  2019-11-25  9:04 ` Daniel Vetter
@ 2019-11-27 13:13 ` Jani Nikula
  2019-11-28  2:01   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 4+ messages in thread
From: Jani Nikula @ 2019-11-27 13:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-kernel
  Cc: David Airlie, dri-devel, Krzysztof Kozlowski

On Thu, 21 Nov 2019, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> 	$ sed -e 's/^        /\t/' -i */Kconfig

Btw have you updated checkpatch.pl to try to keep the Kconfigs from
bitrotting back to having different indentation? Or the config tools?

BR,
Jani.


>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/gpu/drm/vc4/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
> index 7c2317efd5b7..118e8a426b1a 100644
> --- a/drivers/gpu/drm/vc4/Kconfig
> +++ b/drivers/gpu/drm/vc4/Kconfig
> @@ -22,9 +22,9 @@ config DRM_VC4
>  	  our display setup.
>  
>  config DRM_VC4_HDMI_CEC
> -       bool "Broadcom VC4 HDMI CEC Support"
> -       depends on DRM_VC4
> -       select CEC_CORE
> -       help
> +	bool "Broadcom VC4 HDMI CEC Support"
> +	depends on DRM_VC4
> +	select CEC_CORE
> +	help
>  	  Choose this option if you have a Broadcom VC4 GPU
>  	  and want to use CEC.

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/vc4: Fix Kconfig indentation
  2019-11-27 13:13 ` Jani Nikula
@ 2019-11-28  2:01   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2019-11-28  2:01 UTC (permalink / raw)
  To: Jani Nikula; +Cc: linux-kernel, David Airlie, dri-devel

On Wed, 27 Nov 2019 at 21:14, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Thu, 21 Nov 2019, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> >       $ sed -e 's/^        /\t/' -i */Kconfig
>
> Btw have you updated checkpatch.pl to try to keep the Kconfigs from
> bitrotting back to having different indentation? Or the config tools?

Perl is not my domain but I can try. Let's see...

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-28  2:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 13:29 [PATCH] drm/vc4: Fix Kconfig indentation Krzysztof Kozlowski
2019-11-25  9:04 ` Daniel Vetter
2019-11-27 13:13 ` Jani Nikula
2019-11-28  2:01   ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).