* [PATCH for-5.0] ath10k: correct bus type for WCN3990
@ 2019-01-29 23:12 Brian Norris
2019-01-30 6:10 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Brian Norris @ 2019-01-29 23:12 UTC (permalink / raw)
To: Kalle Valo
Cc: ath10k, linux-wireless, Govind Singh, Erik Stromdahl, Wen Gong,
linux-kernel, Brian Norris
WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
This was a regression in 4.20.
drivers/net/wireless/ath/ath10k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 399b501f3c3c..e8891f5fc83a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
{
.id = WCN3990_HW_1_0_DEV_VERSION,
.dev_id = 0,
- .bus = ATH10K_BUS_PCI,
+ .bus = ATH10K_BUS_SNOC,
.name = "wcn3990 hw1.0",
.continuous_frag_desc = true,
.tx_chain_mask = 0x7,
--
2.20.1.495.gaa96b0ce6b-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990
2019-01-29 23:12 [PATCH for-5.0] ath10k: correct bus type for WCN3990 Brian Norris
@ 2019-01-30 6:10 ` Bjorn Andersson
2019-01-30 10:11 ` Kalle Valo
2019-01-31 16:57 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2019-01-30 6:10 UTC (permalink / raw)
To: Brian Norris
Cc: Kalle Valo, ath10k, linux-wireless, Govind Singh, Erik Stromdahl,
Wen Gong, linux-kernel
On Tue 29 Jan 15:12 PST 2019, Brian Norris wrote:
> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> This was a regression in 4.20.
>
> drivers/net/wireless/ath/ath10k/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 399b501f3c3c..e8891f5fc83a 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
> {
> .id = WCN3990_HW_1_0_DEV_VERSION,
> .dev_id = 0,
> - .bus = ATH10K_BUS_PCI,
> + .bus = ATH10K_BUS_SNOC,
> .name = "wcn3990 hw1.0",
> .continuous_frag_desc = true,
> .tx_chain_mask = 0x7,
> --
> 2.20.1.495.gaa96b0ce6b-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990
2019-01-29 23:12 [PATCH for-5.0] ath10k: correct bus type for WCN3990 Brian Norris
2019-01-30 6:10 ` Bjorn Andersson
@ 2019-01-30 10:11 ` Kalle Valo
2019-01-31 16:57 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-01-30 10:11 UTC (permalink / raw)
To: Brian Norris
Cc: ath10k, linux-wireless, Govind Singh, Erik Stromdahl, Wen Gong,
linux-kernel
Brian Norris <briannorris@chromium.org> writes:
> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> This was a regression in 4.20.
I'll queue this for 5.0.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-5.0] ath10k: correct bus type for WCN3990
2019-01-29 23:12 [PATCH for-5.0] ath10k: correct bus type for WCN3990 Brian Norris
2019-01-30 6:10 ` Bjorn Andersson
2019-01-30 10:11 ` Kalle Valo
@ 2019-01-31 16:57 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-01-31 16:57 UTC (permalink / raw)
To: Brian Norris
Cc: ath10k, linux-wireless, Govind Singh, Erik Stromdahl, Wen Gong,
linux-kernel, Brian Norris
Brian Norris <briannorris@chromium.org> wrote:
> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Patch applied to wireless-drivers.git, thanks.
2c2008a63e48 ath10k: correct bus type for WCN3990
--
https://patchwork.kernel.org/patch/10787301/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-31 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 23:12 [PATCH for-5.0] ath10k: correct bus type for WCN3990 Brian Norris
2019-01-30 6:10 ` Bjorn Andersson
2019-01-30 10:11 ` Kalle Valo
2019-01-31 16:57 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).