From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753699AbdDSACs (ORCPT ); Tue, 18 Apr 2017 20:02:48 -0400 Received: from anholt.net ([50.246.234.109]:46596 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757941AbdDSACo (ORCPT ); Tue, 18 Apr 2017 20:02:44 -0400 From: Eric Anholt To: Florian Fainelli , dri-devel@lists.freedesktop.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. In-Reply-To: <7906db2f-cfb8-e2e6-5869-b6e829dd8c6f@gmail.com> References: <20170418191157.18517-1-eric@anholt.net> <20170418233805.15767-1-eric@anholt.net> <7906db2f-cfb8-e2e6-5869-b6e829dd8c6f@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 18 Apr 2017 17:02:42 -0700 Message-ID: <87k26h463h.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Florian Fainelli writes: > On 04/18/2017 04:38 PM, Eric Anholt wrote: >> For the Raspberry Pi's bindings, the power domain also implicitly >> turns on the clock and deasserts reset, but for the new Cygnus port we >> start representing the clock in the devicetree. >>=20 >> v2: Document the clock-names property, check for -ENOENT for no clock >> in DT. >>=20 >> Signed-off-by: Eric Anholt >> --- > >> + if (v3d->clk) >> + clk_disable_unprepare(v3d->clk); > > The clock API allows you to pass a NULL clk and do nothing in these > cases which is what you seem to have done a few lines below, you could > simplify these checks? Sounds good. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlj2qSIACgkQtdYpNtH8 nujV4RAAkkIby7kKKKKgp2s4KVHHopiOR5gSYGkgu1MEMOJa53ThvLvnpytrxtGV LXRyTBIDcdahKDUQ/7kXU4InSbc54Mxr2SGU8RxiNDLLqPdTRb99XIAqxw3kfK45 x/cWZV91n4i0aSfM8kRDgbs1aLLHLwVh6yZ3AI1gEMsFam8W2y0aHk2mEJmGWBAN BXgFY7mqnrmdwAf9lnV0bmYxr9vmpy4NiRRkgES1vnZWHSpWzymoVR7RvaBqyzL5 pzTH4sHNYuihp+utkOMRNO0QGoRbGDN34ICq/IZ2561ay3oJFEH4VrsEmh65aJs9 uU4PD2ZOPUIeJMKMutynca9BjW50NQ+X/aIUV4/vwBdiiCnzmbeO890e9jJ5x+nv jw/ZscFsm9gGct8NVJSfPScJ7mHIHNAIHIJumyUZE5DCal8/C9hY/QaL1UCzCqJl 8cQTrG2oIFbPXl6st4rXBNQ2d7oWdCqJabaksi9XxAA78Pz15vtKULSoNORtdDGI RPG55qsESIXToEROxJ+P5Aqr33NFh2CbBdDtg2N1/Yd4wvCQYHH4/T0sLnMlcq9f p8ONxmsJzu4Qx174FSzvOV7oojeyda7TlGNOQ5kxs7mrMopSjV0LvJNTyB6ekR+x ZnYcQu2tUcQSyVsNHYd6RR/owxkr13qCbWKW0hzpMqNLrxGI/q0= =1nGc -----END PGP SIGNATURE----- --=-=-=--